Skip to content

Use local protobuf when avaliable#208

Open
uis246 wants to merge 1 commit into
rib:masterfrom
uis246:uis
Open

Use local protobuf when avaliable#208
uis246 wants to merge 1 commit into
rib:masterfrom
uis246:uis

Conversation

@uis246

@uis246 uis246 commented Nov 9, 2020

Copy link
Copy Markdown

No description provided.

@djdeath

djdeath commented Nov 9, 2020

Copy link
Copy Markdown
Collaborator

Protobuf might not always be available on the distro used, so I think it's much better to bundle our own version.

@uis246

uis246 commented Nov 9, 2020

Copy link
Copy Markdown
Author

Not always, but when avaliable use system one, when either protobuf-c or protoc unavaliable - fallback to bundled protobuf

@djdeath

djdeath commented Nov 9, 2020

Copy link
Copy Markdown
Collaborator

But what's the advantage? I see more problems of compatibility to deal with.

@uis246

uis246 commented Nov 10, 2020

Copy link
Copy Markdown
Author

Because system protobuf and bundled can conflict. Because when protobuf installed, gcc prefer headers of system one, but link with bundled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants