Moved the logic into a function

[pmikova]

This also fixes an overlooked issue with image verification for non-quay images.

[judovana]

Thanks for bringing it out. I wanted to fill a slightly different issue - what about moving this logic completely out of suite?

The suite expects correct and working URI. If it do not work, it halts (the 200 check and friends). From my previous experiments, the original URI was working (I was running podman run -ti "quay.io/path1/path2/pkgname@sha256:hash", and it worked. Not sure why ot do not work out of the box. Can you please recall why the conversion was needed?
I have two possibilities in mind - to not do any conversions here at all, and simply expect working url. Do a check, and do the conversion only if needed.

Although preferred, The first one is probably bringing to much troubles, as the providers of url are quite dummy and out of control. Also it seems that the the state of URL depends on host. So what about the second one?

Anyway merging this, as having it reusable is much better for any upcoming actions. But please, lets continue a discussion.

oh, Our internal runner is doing something like

   REPO_TAG=`jq...`
   export TEST_DIGEST=`jq ...`
   echo "The Container Image under test is: $REPO_TAG"
   echo "The Container Test_Digest is: $TEST_DIGEST"
   # persist the container to be tested.
   echo $REPO_TAG > image_under_test
   # Set the $TEST_IMAGE value to the $REPO_HASH
   TEST_IMAGE=$REPO_TAG

Maybe you should amend (if exists) or create this file, with adjusted value (unless it is used elsewhere). Or maybe copy it if it exists and recreate so there is vlaid value, but original is possible to locate? (taht would need jenkins job archiver modification)

[judovana]

thanks a lot. Merging now. But the fate of the function shold be please discussed further.