Update tests to work with UBI10 images#47
Conversation
Co-authored-by: Bob (AI Assistant)
vieiro
left a comment
vieiro
left a comment
There was a problem hiding this comment.
I submitted some ideas that may be good (or totally wrong :-( ).
pmikova
force-pushed
the
UBI10_tests_update
branch
from
8b0dfcd to
7823448
Compare
|
Btw, what had |
This is what you are expected to write to a commit message if you use code assist tools. |
| if [[ "$ARG_JDK" == *"quay.io"* ]] && [[ "$ARG_JDK" != *"/v2/"* ]]; then | ||
| # Parse: quay.io/repo/path/image@sha256:digest | ||
| # Convert to: https://quay.io/v2/repo/path/image/manifests/sha256:digest | ||
| QUAY_REPO=$(echo "$ARG_JDK" | sed 's|quay.io/||' | sed 's|@.*||') | ||
| QUAY_DIGEST=$(echo "$ARG_JDK" | grep -oP '@\K.*') | ||
| QUAY_REF="https://quay.io/v2/${QUAY_REPO}/manifests/${QUAY_DIGEST}" | ||
| echo "Converted Quay.io reference to v2 API URL: $QUAY_REF" |
There was a problem hiding this comment.
Please extract it to function.
There was a problem hiding this comment.
I can do that, but is that necessary? It is 8 lines of code which aren't reused anywhere else
There was a problem hiding this comment.
It is single purposed block of code which have clear input and output. Also it needed there liens of comments. I belive this deserves named block - function.
I know. I'm asking what parts of the code it wrote. And if they are used as they were suggested or amended |
judovana
left a comment
judovana
left a comment
There was a problem hiding this comment.
Please elaborate on that 401
4 participants
Co-authored-by: Bob (AI Assistant)