Add system property to allow longer chat messages on legacy versions#1468
Open
Beaness wants to merge 2 commits intoretrooper:2.0from
Open
Add system property to allow longer chat messages on legacy versions#1468Beaness wants to merge 2 commits intoretrooper:2.0from
Beaness wants to merge 2 commits intoretrooper:2.0from
Conversation
Contributor
|
Why don't we keep the current design? And I'm not sure if this will even get merged just because the "LunarClient Apollo API" allows you to change some values. |
Contributor
Author
Fixed
Seems like a minor addition that isn't super hard to maintain, the default value also doesn't change with this pr. |
Beaness
force-pushed
the
legacychatlength
branch
from
cbe81d1 to
646b03e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
https://github.com/PaperMC/Velocity/blob/6aff78728c267bbb67b07298b8cf4580fb79fc6f/proxy/src/main/java/com/velocitypowered/proxy/protocol/packet/chat/legacy/LegacyChatPacket.java#L49
LunarClient Apollo API allows you to override the max chat length message for older mc versions. Without this change plugins that listen for chat packets break.