Skip to content

Remove assert as a reserved keyword #8399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aspeddro wants to merge 9 commits into
base: master
Choose a base branch
from

Reject first-class assert usage

381abce
Select commit
Loading
Failed to load commit list.
Open

Remove assert as a reserved keyword #8399

Reject first-class assert usage
381abce
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 26, 2026 in 1s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

❌ Patch coverage is 52.45902% with 29 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@18175ae). Learn more about missing BASE report.

Files with missing lines Patch % Lines
compiler/syntax/src/res_parens.ml 0.00% 12 Missing ⚠️
compiler/ml/translcore.ml 66.66% 9 Missing ⚠️
compiler/ml/ast_mapper_from0.ml 0.00% 3 Missing ⚠️
compiler/syntax/src/res_grammar.ml 40.00% 3 Missing ⚠️
compiler/ml/typecore.ml 92.30% 1 Missing ⚠️
compiler/syntax/src/res_token.ml 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #8399   +/-   ##
=========================================
  Coverage          ?   60.10%           
=========================================
  Files             ?      373           
  Lines             ?    54224           
  Branches          ?        0           
=========================================
  Hits              ?    32589           
  Misses            ?    21635           
  Partials          ?        0
Files with missing lines Coverage Δ
analysis/src/Utils.ml 9.03% <ø> (ø)
compiler/frontend/bs_ast_mapper.ml 80.74% <ø> (ø)
compiler/ml/ast_helper.ml 70.13% <ø> (ø)
compiler/ml/ast_iterator.ml 85.86% <ø> (ø)
compiler/ml/ast_mapper.ml 53.93% <ø> (ø)
compiler/ml/ast_mapper_to0.ml 10.71% <ø> (ø)
compiler/ml/depend.ml 79.87% <ø> (ø)
compiler/ml/pprintast.ml 0.53% <ø> (ø)
compiler/ml/printast.ml 0.00% <ø> (ø)
compiler/syntax/src/res_comments_table.ml 51.93% <ø> (ø)
... and 8 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov