refactor(ollama): update base URL handling to automatically append /v1 suffix for OpenAI SDK compatibility#31
Merged
RaghavChamadiya merged 1 commit intorepowise-dev:mainfrom Apr 4, 2026
Conversation
…1 suffix for OpenAI SDK compatibility
swati510
approved these changes
Apr 4, 2026
Collaborator
swati510
left a comment
There was a problem hiding this comment.
nit: PR title says "OpenAPI" but should be "OpenAI"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_normalize_base_urlis safe to call on URLs that already have/v1as it won't double-append. This means callers who were already passing/v1(if any) won't break.OLLAMA_BASE_URL=http://localhost:11434is the natural, documented convention that matches Ollama's own docs. The /v1 is an implementation detail of the OpenAI compatibility layer.Related Issues
Closes #30
Test Plan
pytest)ruff check .) (Has errors but not from my changes)npm run build) (if frontend changes)Checklist