[858] IMXRT_LPSPI: Support "LSBF - LSB First" flag#214
Open
simonzumbrunnen wants to merge 1 commit into
Open
Conversation
The default (LSBF = 0) is MSB first. Before this commit the implementation sent the *least significant byte* first but with the *most significant bit* first. This change will break downstream peripherals that expect the mentioned order.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default (LSBF = 0) is MSB first. Before this commit the implementation sent the least significant byte first but with the most significant bit first. This change will break downstream peripherals that expect the mentioned order but it matches what the hardware actually does. To restore the previous behaviour the "BYSW" flag would have to be implemented as well. To use peripherals that expect the previous order the LPSPI peripheral would have to be configured LSBF=1, BYSW=1. If the implementation of BYSW is a requirement for this pull request to be accepted I would be willing to add this change. If not I will most likely create a separate pull request for the "BYSW" sooner or later.
This fixes: #858