fix(force-value-fields) - set force value field as much as json-schema wants#1032
Open
gabrielseco wants to merge 1 commit into
Open
fix(force-value-fields) - set force value field as much as json-schema wants#1032gabrielseco wants to merge 1 commit into
gabrielseco wants to merge 1 commit into
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (312 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
danielcardoso5
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we're using computed properties in a force field value, that can change as it depends on other fields, we weren't setting the correct value into the form
In the loom showcase the problem in main and in this PR
https://www.loom.com/share/929e31718e604e62a99f932f5001649c
Note
Low Risk
Low risk: only adjusts a React
useEffectdependency array so forced values update when inputs change; minimal surface area and no security-sensitive logic.Overview
Ensures
ForcedValueFieldre-applies its forced form value whenevernameorvaluechanges by updating theuseEffectdependency array (and removing the exhaustive-deps suppression). This makes the field follow JSON-schema-driven updates instead of only setting the value once on mount.Reviewed by Cursor Bugbot for commit 9f884a9. Bugbot is set up for automated code reviews on this repo. Configure here.