-
Notifications
You must be signed in to change notification settings - Fork 2
feat: improve site performance and unify analytics #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| 'use client' | ||
|
|
||
| import { lazy, Suspense, useState } from 'react' | ||
|
|
||
| const ContactPopover = lazy(() => | ||
| import('./contact-popover').then(module => ({ | ||
| default: module.ContactPopover | ||
| })) | ||
| ) | ||
|
|
||
| function Trigger({ | ||
| onLoad, | ||
| onOpen | ||
| }: { | ||
| onLoad: () => void | ||
| onOpen: () => void | ||
| }) { | ||
| return ( | ||
| <div className="relative inline-block text-left"> | ||
| <button | ||
| type="button" | ||
| aria-haspopup="dialog" | ||
| aria-expanded={false} | ||
| onPointerEnter={onLoad} | ||
| onFocus={onLoad} | ||
| onClick={onOpen} | ||
| className="text-muted-foreground hover:text-foreground transition-colors text-sm font-medium" | ||
| > | ||
| Contact | ||
| </button> | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| /** | ||
| * Defers loading the popover (and its motion dependency) until the user | ||
| * hovers, focuses, or clicks the trigger, keeping it out of the initial | ||
| * bundle of every page that renders the footer. | ||
| */ | ||
| export function LazyContactPopover() { | ||
| const [load, setLoad] = useState(false) | ||
| const [open, setOpen] = useState(false) | ||
|
|
||
| function handleLoad() { | ||
| setLoad(true) | ||
| } | ||
|
|
||
| function handleOpen() { | ||
| setLoad(true) | ||
| setOpen(true) | ||
| } | ||
|
|
||
| if (!load) return <Trigger onLoad={handleLoad} onOpen={handleOpen} /> | ||
|
|
||
| return ( | ||
| <Suspense | ||
| fallback={<Trigger onLoad={handleLoad} onOpen={handleOpen} />} | ||
| > | ||
| <ContactPopover initialOpen={open} /> | ||
| </Suspense> | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| 'use client' | ||
|
|
||
| import { lazy, Suspense, useState } from 'react' | ||
| import { FileUser } from 'lucide-react' | ||
|
|
||
| const ResumeDrawer = lazy(() => | ||
| import('./resume-drawer').then(module => ({ | ||
| default: module.ResumeDrawer | ||
| })) | ||
| ) | ||
|
|
||
| function Trigger({ | ||
| onLoad, | ||
| onOpen | ||
| }: { | ||
| onLoad: () => void | ||
| onOpen: () => void | ||
| }) { | ||
| return ( | ||
| <button | ||
| type="button" | ||
| onPointerEnter={onLoad} | ||
| onFocus={onLoad} | ||
| onClick={onOpen} | ||
| className="flex items-center gap-2 text-sm text-muted-foreground hover:text-foreground transition-colors" | ||
| > | ||
| <FileUser className="w-4 h-4" /> | ||
| <span>Resume</span> | ||
| </button> | ||
| ) | ||
| } | ||
|
|
||
| /** | ||
| * Defers loading the drawer (and its vaul dependency) until the user hovers, | ||
| * focuses, or clicks the trigger, keeping it out of the initial bundle of | ||
| * every page that renders the footer. | ||
| */ | ||
| export function LazyResumeDrawer() { | ||
| const [load, setLoad] = useState(false) | ||
| const [open, setOpen] = useState(false) | ||
|
|
||
| function handleLoad() { | ||
| setLoad(true) | ||
| } | ||
|
|
||
| function handleOpen() { | ||
| setLoad(true) | ||
| setOpen(true) | ||
| } | ||
|
|
||
| if (!load) return <Trigger onLoad={handleLoad} onOpen={handleOpen} /> | ||
|
|
||
| return ( | ||
| <Suspense | ||
| fallback={<Trigger onLoad={handleLoad} onOpen={handleOpen} />} | ||
| > | ||
| <ResumeDrawer initialOpen={open} /> | ||
| </Suspense> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The lazy contact trigger hard-codes
aria-expanded={false}, and the resume trigger exposes no expanded state at all; while the lazy module is loading after activation, assistive technology is told that the control is closed even though the user has requested it to open.Triggers: When a user activates the trigger before its lazy module has finished loading.
Suggested fix: Pass the open state into
Triggerand expose it througharia-expanded(and an appropriate relationship to the pending dialog/drawer).