feat: Cashu improvements#653
Open
frnandu wants to merge 14 commits into
Open
Conversation
feat: add reclaim triggers for cashu pending transactions feat: add backup/restore of cash seed & db proofs
|
Warning Review limit reached
More reviews will be available in 12 minutes and 27 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughAdds Cashu state export/import with JSON map/string APIs, wires those into Cashu and the ndk barrel, implements persistent Cashu seed storage and a one-time backup warning UI, refactors wallet action dialogs into a reusable mixin (reclaim/backup/restore/send/receive flows), extends transaction models for serialization, expands localization for backup/restore flows, and updates the sample app and Android toolchain. ChangesCashu export/import engine and public wiring
Seed storage, backup warning widget, and wallet list integration
Wallet action dialogs and dialog orchestration mixin
Wallet widgets adopt dialog mixin and UI updates
Localization interface, keys, and implementations
Sample app runtime initialization and Android toolchain updates
🎯 4 (Complex) | ⏱️ ~45 minutes Suggested labels: Suggested reviewers:
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 19
🧹 Nitpick comments (3)
packages/sample-app/android/gradle/wrapper/gradle-wrapper.properties (1)
5-5: ⚡ Quick winConsider aligning Gradle version with ndk_flutter module.
The sample-app is using Gradle 8.11.1, while the
packages/ndk_flutter/android/gradle/wrapper/gradle-wrapper.propertiesuses Gradle 8.14 (see context snippet 1). Using different Gradle versions across modules in the same repository can lead to inconsistent build behavior and subtle issues.Consider updating to Gradle 8.14 for consistency:
📦 Suggested version alignment
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-all.zip🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/sample-app/android/gradle/wrapper/gradle-wrapper.properties` at line 5, Update the distributionUrl in packages/sample-app/android/gradle/wrapper/gradle-wrapper.properties (the distributionUrl property currently set to gradle-8.11.1-all.zip) to use Gradle 8.14 (match packages/ndk_flutter's gradle-wrapper.properties) so both modules use the same Gradle version; modify the distributionUrl value to point to the gradle-8.14-all.zip distribution.packages/ndk_flutter/lib/l10n/app_en.arb (1)
1156-1162: ⚡ Quick winAdd ARB metadata for
backupSeed*keys to preserve translator context.
backupSeedWarning,backupSeedTitle,backupSeedInstructions,backupSeedConfirm, andbackupSeedDoneare missing@...descriptionentries, unlike the neighboring new keys. Adding descriptions keeps localization generation/docs consistent and reduces ambiguity for translators.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ndk_flutter/lib/l10n/app_en.arb` around lines 1156 - 1162, Add ARB metadata description entries for the missing keys backupSeedWarning, backupSeedTitle, backupSeedInstructions, backupSeedConfirm, and backupSeedDone so translators have context; for each key add a corresponding "@<key>" JSON string giving a short description/purpose and any notes (e.g., whether it's a title, button label, or instructional text) consistent with neighboring metadata entries like the ones around reclaimPendingFunds/reclaimPendingTitle so localization generation and docs remain consistent.packages/ndk_flutter/lib/l10n/app_localizations.dart (1)
2214-2290: 🏗️ Heavy liftComplete non-English translations for the newly introduced backup/restore contract keys.
These new keys are in the public localization interface, but in the provided locale ARBs only English has the full backup/restore set (
backup,restore,cashuBackupTitle,cashuBackupWarning,generatingBackup,copyBackup,backupCopiedToClipboard,cashuRestoreTitle,backupJson,backupJsonHint,pleaseEnterBackup,restoringBackup,restoreSuccess). This will show mixed English UI in backup/restore dialogs for non-English locales.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ndk_flutter/lib/l10n/app_localizations.dart` around lines 2214 - 2290, The new localization getters (backup, restore, cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup, restoringBackup, and restoreSuccess) are only defined in English ARB — causing mixed-language UI for other locales; add these keys with appropriate translations to each non-English ARB, ensure restoreSuccess(int count) has correct plural/placeholder syntax for those locales, then re-run the project's localization generation (e.g., flutter gen-l10n or your intl generator) so the generated AppLocalizations includes the new strings for all locales.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ndk_flutter/lib/l10n/app_localizations_de.dart`:
- Around line 1097-1137: All of the new overrides in app_localizations_de.dart
(backup, restore, cashuBackupTitle, cashuBackupWarning, generatingBackup,
copyBackup, backupCopiedToClipboard, cashuRestoreTitle, backupJson,
backupJsonHint, pleaseEnterBackup, restoringBackup, and restoreSuccess) are
still in English; replace each English string with proper German translations
(and update the restoreSuccess(int count) return string to use correct German
pluralization/wording) so the German localization is fully localized rather than
showing mixed-language UI.
In `@packages/ndk_flutter/lib/l10n/app_localizations_es.dart`:
- Around line 1098-1138: The Spanish localization class contains English strings
for backup/restore UI; update the getters and the restoreSuccess(int count)
method in app_localizations_es.dart (symbols: backup, restore, cashuBackupTitle,
cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard,
cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup,
restoringBackup, restoreSuccess) to Spanish translations so the UI is fully
localized; keep the same method/getter names and interpolation in restoreSuccess
but replace the returned text with the correct Spanish phrasing.
In `@packages/ndk_flutter/lib/l10n/app_localizations_fi.dart`:
- Around line 1095-1135: The Finnish localization file has untranslated English
strings in the generated class (see getters backup, restore, cashuBackupTitle,
cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard,
cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup,
restoringBackup and the restoreSuccess(int) message); update the corresponding
keys in app_fi.arb with proper Finnish translations for each of these entries
and then regenerate the localization files (run your localization generation
tool) so the generated AppLocalizationsFi class contains Finnish text instead of
English literals.
In `@packages/ndk_flutter/lib/l10n/app_localizations_fr.dart`:
- Around line 1098-1138: The French localization class AppLocalizationsFr
contains untranslated English strings for keys/methods backup, restore,
cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup,
backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint,
pleaseEnterBackup, restoringBackup and restoreSuccess; update these keys in
app_fr.arb with proper French translations (including plural/interpolated form
for restoreSuccess) and then regenerate the Dart localization files so
AppLocalizationsFr reflects the translated text.
In `@packages/ndk_flutter/lib/l10n/app_localizations_it.dart`:
- Around line 1099-1139: The Italian localization entries for backup/restore are
still in English; update the corresponding keys in app_it.arb (backup, restore,
cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup,
backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint,
pleaseEnterBackup, restoringBackup, restoreSuccess) with proper Italian
translations, then run the localization generation tool to regenerate
AppLocalizationsIt (so the class and its getters/methods reflect the Italian
strings).
In `@packages/ndk_flutter/lib/l10n/app_localizations_ja.dart`:
- Around line 1084-1124: The Japanese localization file AppLocalizationsJa
contains English strings for backup/restore (methods/gets: backup, restore,
cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup,
backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint,
pleaseEnterBackup, restoringBackup and function restoreSuccess), so update
app_ja.arb with proper Japanese translations for each corresponding key
(matching these symbol names) and then regenerate the Dart localization stubs
(run the Flutter gen-l10n/localization generation) so AppLocalizationsJa returns
the Japanese text instead of the English literals.
In `@packages/ndk_flutter/lib/l10n/app_localizations_pl.dart`:
- Around line 1097-1137: The Polish translations for the backup/restore strings
are missing in AppLocalizationsPl (fields/methods: backup, restore,
cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup,
backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint,
pleaseEnterBackup, restoringBackup, restoreSuccess); update the corresponding
keys in app_pl.arb with proper Polish translations for each key (including the
plural/parameterized restoreSuccess) and then regenerate the Dart localization
files so AppLocalizationsPl is rebuilt with the translated strings.
In `@packages/ndk_flutter/lib/l10n/app_localizations_pt.dart`:
- Around line 1101-1141: AppLocalizationsPt currently exposes English texts for
the backup/restore keys (methods/props like backup, restore, cashuBackupTitle,
cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard,
cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup,
restoringBackup, restoreSuccess) so pt_BR ends up inheriting English; add
correct Portuguese translations for these keys in app_pt.arb (and app_pt_BR.arb
if you want region-specific variants) and then regenerate the Flutter
localization files (flutter gen-l10n) so AppLocalizationsPt and
AppLocalizationsPtBr contain the localized strings instead of the current
English ones.
In `@packages/ndk_flutter/lib/l10n/app_localizations_ru.dart`:
- Around line 1096-1136: AppLocalizationsRu currently contains English strings
for backup/restore (properties: backup, restore, cashuBackupTitle,
cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard,
cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup,
restoringBackup and method restoreSuccess(int)), so update app_ru.arb with
proper Russian translations for each corresponding key and then run the
localization generation step (e.g., Flutter gen_l10n or your project's
localization script) to regenerate AppLocalizationsRu so the class contains the
Russian text instead of English.
In `@packages/ndk_flutter/lib/l10n/app_localizations_zh.dart`:
- Around line 1083-1123: The backup/restore strings in AppLocalizationsZh (e.g.,
getters backup, restore, cashuBackupTitle, cashuBackupWarning, generatingBackup,
copyBackup, backupCopiedToClipboard, cashuRestoreTitle, backupJson,
backupJsonHint, pleaseEnterBackup, restoringBackup and the method
restoreSuccess) are still in English; update their translations by adding
Chinese equivalents into the app_zh.arb resource file for each corresponding
key, then run the localization generation (e.g., Flutter gen-l10n or your i18n
build script) to regenerate the AppLocalizationsZh class so the Dart file
contains the proper Chinese strings.
In `@packages/ndk_flutter/lib/l10n/app_pt.arb`:
- Around line 288-290: The new pt locale strings use Brazilian Portuguese
phrasing; update the three keys backupSeedInstructions, backupSeedConfirm, and
backupSeedDone in app_pt.arb to European Portuguese equivalents (e.g., use
"Anote estas palavras pela ordem e guarde‑as num local seguro. São a única forma
de recuperar os seus fundos cashu se perder este equipamento." for
backupSeedInstructions, "Anotei a minha frase de recuperação e guardei‑a em
segurança" for backupSeedConfirm, and "Backup concluído" or "Já efetuei o
backup" for backupSeedDone) so the wording, pronouns, and terms (e.g.,
"equipamento" vs "dispositivo", "num local" vs "em um lugar") match pt-PT
conventions.
In `@packages/ndk_flutter/lib/repositories/cashu_seed_store.dart`:
- Around line 15-23: The backed-up flag is currently a single static key
(_backedUpKey) while CashuSeedStore allows custom _seedKey, causing cross-seed
collisions; change the implementation to derive a per-instance backup key (e.g.,
compute a backedUpKey using the instance _seedKey like "${_seedKey}_backed_up"
or provide a getter) instead of the static const _backedUpKey, and update all
uses in CashuSeedStore methods (the getters/setters that read/write the backup
flag around lines 47-52) to use this instance-backedUpKey so each seed namespace
has its own backup status.
In `@packages/ndk_flutter/lib/widgets/wallets/n_wallets.dart`:
- Line 160: The NWallets widget currently constructs NCashuSeedBackupWarning
without supplying a seedStore, hardcoding the default seed-store wiring and
preventing apps with custom seed keys from aligning backup-status storage;
modify NWallets to accept an optional seedStore (or use the existing seedStore
on widget.ndkFlutter if available) and forward it into both
NCashuSeedBackupWarning(...) instances via the seedStore constructor parameter
so the banner reads/writes backup status from the app-provided store rather than
the hardcoded default.
In `@packages/ndk_flutter/lib/widgets/wallets/wallet_action_dialogs.dart`:
- Around line 21-23: The reclaimablePending filter allows empty usedKeysets
which later causes a runtime dereference of the first keyset; update the filter
that checks tx.usedKeysets (in the reclaimablePending predicate) to require a
non-empty list (e.g., tx.usedKeysets != null && tx.usedKeysets.isNotEmpty) so
empty arrays are rejected before reclaim logic access tx.usedKeysets[0].
- Around line 850-852: The post-frame callback unconditionally calls
Navigator.of(dialogContext).pop(), which can run after the dialog was disposed;
guard the pop by checking the navigator state is still mounted and canPop before
calling pop (e.g. use Navigator.of(dialogContext) to get the NavigatorState and
verify mounted && canPop()), and only then call pop and show the snackbar (leave
scaffoldMessenger.showSnackBar as-is but run it inside the same guarded block).
In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dart`:
- Around line 179-251: importFromMap currently applies side effects while
parsing, risking partial restores; first fully parse and validate the entire
payload into local in-memory structures (e.g., restoredSeedPhrase string,
List<CashuMintInfo> mintInfos, List<CahsuKeyset> keysets,
Map<String,List<CashuProof>> proofsByMint, List<counter maps>, List<Transaction>
parsedTransactions) without calling mutating APIs, then if validation passes
perform the persistence/side-effect phase in order: call
_cashuSeed.setSeedPhrase (only if restoreSeedPhrase), then
_cacheManager.saveMintInfo for each CashuMintInfo, _cacheManagerCashu.saveKeyset
for each CahsuKeyset, _cacheManagerCashu.saveProofs per proofsByMint entry,
_cacheManager.setCashuSecretCounter for each counter, and finally
_walletsRepo.saveTransactions with parsedTransactions; ensure any parse errors
abort before any of those mutating calls.
In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu.dart`:
- Around line 149-176: Both importBackup and importBackupJsonString refresh only
balances; after the import (i.e., after
_cashuBackup.importFromMap/_cashuBackup.importFromJsonString and
_updateBalances()), also refresh and push restored transactions into the
transaction subjects so subscribers see updates — call the internal routine that
loads/publishes transactions (or implement one) and ensure it updates
pendingTransactions and latestTransactions subjects (e.g., invoke
_updateTransactions() or explicitly add/publish to pendingTransactions and
latestTransactions) in both importBackup and importBackupJsonString.
In `@packages/sample-app/android/build.gradle`:
- Line 2: The Kotlin version declaration ext.kotlin_version = '2.3.21' must be
validated for compatibility with the Kotlin Gradle Plugin, Gradle, AGP and the
JVM toolchain and kept consistent across Android modules; verify that Kotlin
2.3.21 is the intended released target, update the Kotlin Gradle plugin
dependency and any module-level Kotlin version pins (e.g.,
packages/ndk_flutter/android/build.gradle) to the same compatible version or
explicitly document why a different version is required, and ensure the project
Gradle and Android Gradle Plugin versions and JDK/toolchain meet Kotlin 2.3.21
compatibility before merging.
In `@packages/sample-app/lib/main.dart`:
- Around line 46-49: The Cashu seed initialization can throw before runApp, so
wrap the call to CashuSeedStore().loadOrCreate() in a try/catch and on error set
cashuSeedPhrase to null (or a safe fallback) instead of letting the exception
bubble; ensure the variable passed to runApp (cashuUserSeedphrase) uses this
guarded value. Do the same guarding for the other initialization site referenced
(the lines around the second loadOrCreate call), and ensure downstream code that
consumes cashuUserSeedphrase tolerates null (degrade behavior) so the app can
still boot.
---
Nitpick comments:
In `@packages/ndk_flutter/lib/l10n/app_en.arb`:
- Around line 1156-1162: Add ARB metadata description entries for the missing
keys backupSeedWarning, backupSeedTitle, backupSeedInstructions,
backupSeedConfirm, and backupSeedDone so translators have context; for each key
add a corresponding "@<key>" JSON string giving a short description/purpose and
any notes (e.g., whether it's a title, button label, or instructional text)
consistent with neighboring metadata entries like the ones around
reclaimPendingFunds/reclaimPendingTitle so localization generation and docs
remain consistent.
In `@packages/ndk_flutter/lib/l10n/app_localizations.dart`:
- Around line 2214-2290: The new localization getters (backup, restore,
cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup,
backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint,
pleaseEnterBackup, restoringBackup, and restoreSuccess) are only defined in
English ARB — causing mixed-language UI for other locales; add these keys with
appropriate translations to each non-English ARB, ensure restoreSuccess(int
count) has correct plural/placeholder syntax for those locales, then re-run the
project's localization generation (e.g., flutter gen-l10n or your intl
generator) so the generated AppLocalizations includes the new strings for all
locales.
In `@packages/sample-app/android/gradle/wrapper/gradle-wrapper.properties`:
- Line 5: Update the distributionUrl in
packages/sample-app/android/gradle/wrapper/gradle-wrapper.properties (the
distributionUrl property currently set to gradle-8.11.1-all.zip) to use Gradle
8.14 (match packages/ndk_flutter's gradle-wrapper.properties) so both modules
use the same Gradle version; modify the distributionUrl value to point to the
gradle-8.14-all.zip distribution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b6727b6c-c134-4545-84d3-1e6c30724ee6
⛔ Files ignored due to path filters (1)
packages/sample-app/pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (44)
packages/ndk/lib/domain_layer/usecases/cashu/cashu.dartpackages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dartpackages/ndk/lib/ndk.dartpackages/ndk/test/cashu/cashu_backup_test.dartpackages/ndk_flutter/lib/l10n/app_de.arbpackages/ndk_flutter/lib/l10n/app_en.arbpackages/ndk_flutter/lib/l10n/app_es.arbpackages/ndk_flutter/lib/l10n/app_fi.arbpackages/ndk_flutter/lib/l10n/app_fr.arbpackages/ndk_flutter/lib/l10n/app_it.arbpackages/ndk_flutter/lib/l10n/app_ja.arbpackages/ndk_flutter/lib/l10n/app_localizations.dartpackages/ndk_flutter/lib/l10n/app_localizations_de.dartpackages/ndk_flutter/lib/l10n/app_localizations_en.dartpackages/ndk_flutter/lib/l10n/app_localizations_es.dartpackages/ndk_flutter/lib/l10n/app_localizations_fi.dartpackages/ndk_flutter/lib/l10n/app_localizations_fr.dartpackages/ndk_flutter/lib/l10n/app_localizations_it.dartpackages/ndk_flutter/lib/l10n/app_localizations_ja.dartpackages/ndk_flutter/lib/l10n/app_localizations_pl.dartpackages/ndk_flutter/lib/l10n/app_localizations_pt.dartpackages/ndk_flutter/lib/l10n/app_localizations_ru.dartpackages/ndk_flutter/lib/l10n/app_localizations_zh.dartpackages/ndk_flutter/lib/l10n/app_pl.arbpackages/ndk_flutter/lib/l10n/app_pt.arbpackages/ndk_flutter/lib/l10n/app_pt_BR.arbpackages/ndk_flutter/lib/l10n/app_ru.arbpackages/ndk_flutter/lib/l10n/app_zh.arbpackages/ndk_flutter/lib/ndk_flutter.dartpackages/ndk_flutter/lib/repositories/cashu_seed_store.dartpackages/ndk_flutter/lib/widgets/wallets/n_cashu_seed_backup_warning.dartpackages/ndk_flutter/lib/widgets/wallets/n_pending_transactions.dartpackages/ndk_flutter/lib/widgets/wallets/n_wallet_actions.dartpackages/ndk_flutter/lib/widgets/wallets/n_wallet_card.dartpackages/ndk_flutter/lib/widgets/wallets/n_wallets.dartpackages/ndk_flutter/lib/widgets/wallets/wallet_action_dialogs.dartpackages/ndk_flutter/lib/widgets/widgets.dartpackages/sample-app/android/app/build.gradlepackages/sample-app/android/build.gradlepackages/sample-app/android/gradle.propertiespackages/sample-app/android/gradle/wrapper/gradle-wrapper.propertiespackages/sample-app/android/settings.gradlepackages/sample-app/lib/demo_app_config.dartpackages/sample-app/lib/main.dart
💤 Files with no reviewable changes (1)
- packages/sample-app/lib/demo_app_config.dart
Comment on lines
+850
to
+852
| WidgetsBinding.instance.addPostFrameCallback((_) { | ||
| Navigator.of(dialogContext).pop(); | ||
| scaffoldMessenger.showSnackBar( |
There was a problem hiding this comment.
Guard post-frame dialog pop with mounted check.
The callback can run after dialog disposal. Popping unconditionally risks navigator errors or popping the wrong route.
Patch
WidgetsBinding.instance.addPostFrameCallback((_) {
- Navigator.of(dialogContext).pop();
+ if (!dialogContext.mounted) return;
+ Navigator.of(dialogContext).pop();
scaffoldMessenger.showSnackBar(📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| WidgetsBinding.instance.addPostFrameCallback((_) { | |
| Navigator.of(dialogContext).pop(); | |
| scaffoldMessenger.showSnackBar( | |
| WidgetsBinding.instance.addPostFrameCallback((_) { | |
| if (!dialogContext.mounted) return; | |
| Navigator.of(dialogContext).pop(); | |
| scaffoldMessenger.showSnackBar( |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ndk_flutter/lib/widgets/wallets/wallet_action_dialogs.dart` around
lines 850 - 852, The post-frame callback unconditionally calls
Navigator.of(dialogContext).pop(), which can run after the dialog was disposed;
guard the pop by checking the navigator state is still mounted and canPop before
calling pop (e.g. use Navigator.of(dialogContext) to get the NavigatorState and
verify mounted && canPop()), and only then call pop and show the snackbar (leave
scaffoldMessenger.showSnackBar as-is but run it inside the same guarded block).
| @@ -1,5 +1,5 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '2.1.0' | |||
| ext.kotlin_version = '2.3.21' | |||
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Is Kotlin version 2.3.21 available and what are its compatibility requirements?
💡 Result:
Yes—Kotlin 2.3.21 is available. JetBrains’ official release tag shows “Kotlin 2.3.21” published on 2026-04-23 [1], and the Kotlin release process documentation lists “2.3.21” as a bug-fix release released April 23, 2026 [2]. Compatibility requirements (what you need to match when using 2.3.21): 1) Use the Kotlin Gradle plugin (KGP) version that matches Kotlin 2.3.21. - Kotlin’s Multiplatform compatibility guide instructs you to check compatibility of the Kotlin Multiplatform Gradle plugin version (the same as the Kotlin version in your project) with Gradle, Xcode, and Android Gradle plugin versions [3]. 2) Kotlin Multiplatform: check KGP ↔ Gradle/Xcode/AGP version compatibility for the 2.3.20–2.3.21 range. - The same compatibility guide explicitly includes a section covering “2.3.20–2.3.21” for Gradle/Xcode/Android Gradle plugin compatibility checks [3]. 3) JVM builds (and any Kotlin/JVM compile): ensure your project’s JVM target/toolchain settings are consistent with the Gradle JDK/toolchain you’re using. - Kotlin’s Gradle configuration documentation notes default JVM target translation behavior and warns about mismatches between jvmTarget/Java targetCompatibility and the JDK used by the build; it recommends configuring a toolchain or aligning JVM versions to avoid incompatibility [4]. What I could not find as a single simple “minimum Gradle/JDK version” statement specifically for 2.3.21 in the sources retrieved: the authoritative place to get exact minimum/maximum supported versions is the official compatibility guide (it’s organized by Kotlin/KGP version ranges, including 2.3.20–2.3.21) [3].
Citations:
- 1: https://github.com/JetBrains/kotlin/releases/tag/v2.3.21
- 2: https://kotlinlang.org/docs/releases.html
- 3: https://kotlinlang.org/docs/multiplatform/multiplatform-compatibility-guide.html
- 4: https://kotlinlang.org/docs/gradle-configure-project.html
Confirm Kotlin 2.3.21 release and validate Gradle/JDK/AGP compatibility (and align modules)
ext.kotlin_version = '2.3.21'
Kotlin 2.3.21 is a published JetBrains release. Compatibility depends on using the matching Kotlin Gradle plugin (KGP) / Kotlin version and ensuring your Gradle + Android Gradle Plugin (AGP) + JVM toolchain/JDK are aligned with Kotlin’s compatibility guidance (Kotlin Multiplatform compatibility guide includes the relevant 2.3.20–2.3.21 range).
If other Android modules (e.g., packages/ndk_flutter/android/build.gradle) still pin Kotlin 2.1.0, align the Kotlin/KGP versions or document why they intentionally differ.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/sample-app/android/build.gradle` at line 2, The Kotlin version
declaration ext.kotlin_version = '2.3.21' must be validated for compatibility
with the Kotlin Gradle Plugin, Gradle, AGP and the JVM toolchain and kept
consistent across Android modules; verify that Kotlin 2.3.21 is the intended
released target, update the Kotlin Gradle plugin dependency and any module-level
Kotlin version pins (e.g., packages/ndk_flutter/android/build.gradle) to the
same compatible version or explicitly document why a different version is
required, and ensure the project Gradle and Android Gradle Plugin versions and
JDK/toolchain meet Kotlin 2.3.21 compatibility before merging.
Comment on lines
+46
to
+49
| // Load the cashu seed phrase from secure storage, generating a fresh one on | ||
| // first run. Never hardcode this — it controls cashu funds. | ||
| final cashuSeedPhrase = await CashuSeedStore().loadOrCreate(); | ||
|
|
There was a problem hiding this comment.
Guard seed-store initialization to avoid app boot failure.
Line 48 can throw before runApp, which makes startup fail hard. Add an explicit fallback path (or degrade with cashuUserSeedphrase: null) so the app can still boot.
Suggested fix
- final cashuSeedPhrase = await CashuSeedStore().loadOrCreate();
+ String? cashuSeedPhrase;
+ try {
+ cashuSeedPhrase = await CashuSeedStore().loadOrCreate();
+ } catch (e, st) {
+ debugPrint('Failed to initialize Cashu seed storage: $e');
+ FlutterError.reportError(
+ FlutterErrorDetails(
+ exception: e,
+ stack: st,
+ context: ErrorDescription('while loading Cashu seed phrase'),
+ ),
+ );
+ }
@@
- cashuUserSeedphrase: CashuUserSeedphrase(
- seedPhrase: cashuSeedPhrase,
- ),
+ cashuUserSeedphrase: cashuSeedPhrase == null
+ ? null
+ : CashuUserSeedphrase(seedPhrase: cashuSeedPhrase),Also applies to: 57-59
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/sample-app/lib/main.dart` around lines 46 - 49, The Cashu seed
initialization can throw before runApp, so wrap the call to
CashuSeedStore().loadOrCreate() in a try/catch and on error set cashuSeedPhrase
to null (or a safe fallback) instead of letting the exception bubble; ensure the
variable passed to runApp (cashuUserSeedphrase) uses this guarded value. Do the
same guarding for the other initialization site referenced (the lines around the
second loadOrCreate call), and ensure downstream code that consumes
cashuUserSeedphrase tolerates null (degrade behavior) so the app can still boot.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dart (1)
173-176:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winReject unsupported older backup versions too.
This guard only rejects versions greater than
backupVersion, so0or other unhandled older versions still enter the v1 restore path even though there is no migration logic for them. For a versioned backup format, accept only versions you explicitly support.Suggested fix
final version = json['version']; - if (version is! int || version > backupVersion) { + if (version != backupVersion) { throw ArgumentError( - 'Unsupported backup version: $version (this build supports up to $backupVersion)'); + 'Unsupported backup version: $version (expected $backupVersion)'); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dart` around lines 173 - 176, The current guard only rejects versions greater than backupVersion but allows older unsupported versions; change the check in the Cashu backup JSON parsing (the variables `version` and `backupVersion`) to accept only explicitly supported versions (e.g., require `version == backupVersion` or membership in a supportedVersions set) and throw an ArgumentError for any other value (including older ones), updating the error message to reflect unsupported version values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dart`:
- Around line 216-217: The code currently defaults a missing/nullable proof
state to 'UNSPENT' when calling CashuProofState.fromValue(map['state'] as
String? ?? 'UNSPENT'); change this so a missing or null map['state'] does not
get silently treated as UNSPENT: remove the fallback and explicitly reject or
throw for null/unknown states (e.g., check map['state'] as String? and if
null/invalid throw a descriptive exception or return a failure) so
malformed/legacy payloads are refused; ensure callers such as
Cashu.importBackup*() handle the new error path or provide an explicit migration
before accepting missing state.
---
Outside diff comments:
In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dart`:
- Around line 173-176: The current guard only rejects versions greater than
backupVersion but allows older unsupported versions; change the check in the
Cashu backup JSON parsing (the variables `version` and `backupVersion`) to
accept only explicitly supported versions (e.g., require `version ==
backupVersion` or membership in a supportedVersions set) and throw an
ArgumentError for any other value (including older ones), updating the error
message to reflect unsupported version values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 80450a46-52f1-4e95-ba52-02052b14b82a
📒 Files selected for processing (3)
packages/ndk/lib/domain_layer/usecases/cashu/cashu.dartpackages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dartpackages/ndk/test/cashu/cashu_backup_test.dart
🚧 Files skipped from review as they are similar to previous changes (2)
- packages/ndk/lib/domain_layer/usecases/cashu/cashu.dart
- packages/ndk/test/cashu/cashu_backup_test.dart
Comment on lines
+216
to
+217
| state: | ||
| CashuProofState.fromValue(map['state'] as String? ?? 'UNSPENT'), |
There was a problem hiding this comment.
Do not default a missing proof state to UNSPENT.
The exporter always writes state, so this fallback only affects malformed or legacy payloads. Treating an unknown proof lifecycle as UNSPENT can inflate restored balances, and Cashu.importBackup*() refreshes balances immediately after restore, so the bad state becomes user-visible right away. Reject missing state unless you add an explicit migration path. Based on downstream balance refresh behavior in packages/ndk/lib/domain_layer/usecases/cashu/cashu.dart:128-161.
Suggested fix
- state:
- CashuProofState.fromValue(map['state'] as String? ?? 'UNSPENT'),
+ state: CashuProofState.fromValue(
+ map['state'] as String? ??
+ (throw ArgumentError('Proof state is required')),
+ ),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu_backup.dart` around lines
216 - 217, The code currently defaults a missing/nullable proof state to
'UNSPENT' when calling CashuProofState.fromValue(map['state'] as String? ??
'UNSPENT'); change this so a missing or null map['state'] does not get silently
treated as UNSPENT: remove the fallback and explicitly reject or throw for
null/unknown states (e.g., check map['state'] as String? and if null/invalid
throw a descriptive exception or return a failure) so malformed/legacy payloads
are refused; ensure callers such as Cashu.importBackup*() handle the new error
path or provide an explicit migration before accepting missing state.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 71.94% 72.07% +0.12%
==========================================
Files 210 212 +2
Lines 10698 10993 +295
==========================================
+ Hits 7697 7923 +226
- Misses 3001 3070 +69 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1-leo
reviewed
Jun 9, 2026
1-leo
left a comment
1-leo
left a comment
Contributor
There was a problem hiding this comment.
- going through it a second time
| } | ||
|
|
||
| class _NCashuSeedBackupWarningState extends State<NCashuSeedBackupWarning> { | ||
| late final CashuSeedStore _seedStore = widget.seedStore ?? CashuSeedStore(); |
Contributor
There was a problem hiding this comment.
not sure about this default.
Could be pron to mistakes by implicit init.
Wdyt?
Contributor
There was a problem hiding this comment.
I think its better to move this up the chain so its easier to spot for the dev and we can keep the implicit seed ux
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
packages/ndk/lib/domain_layer/usecases/cashu/cashu_cache_decorator.dart (1)
168-178:⚠️ Potential issue | 🟡 Minor | ⚡ Quick win
setDerivationCounterbypasses mutex synchronization.The newly added
setCashuSecretCounter(lines 110-123) correctly wraps the delegate call in_mutex.synchronized, but the existingsetDerivationCountercalls_delegate.setCashuSecretCounterdirectly without synchronization. This inconsistency could cause race conditions if both methods are used concurrently.Suggested fix
Future<void> setDerivationCounter({ required String keysetId, required String mintUrl, required int counter, }) async { - await _delegate.setCashuSecretCounter( - mintUrl: mintUrl, - keysetId: keysetId, - counter: counter, - ); + await _mutex.synchronized(() async { + await _delegate.setCashuSecretCounter( + mintUrl: mintUrl, + keysetId: keysetId, + counter: counter, + ); + }); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu_cache_decorator.dart` around lines 168 - 178, The setDerivationCounter method currently calls _delegate.setCashuSecretCounter directly and bypasses the mutex; wrap the delegate call inside _mutex.synchronized (same pattern used in setCashuSecretCounter) to ensure serialized access. Inside setDerivationCounter, call _mutex.synchronized(() async { await _delegate.setCashuSecretCounter(mintUrl: mintUrl, keysetId: keysetId, counter: counter); }); keeping the same parameter mapping and error propagation.packages/ndk_flutter/lib/l10n/app_zh.arb (1)
1-377:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMissing ARB keys for backup/restore functionality.
The Chinese ARB file is missing the same backup/restore dialog keys as the Russian locale:
backup,restore,cashuBackupTitle,cashuBackupWarning,generatingBackup,copyBackup,backupCopiedToClipboard,cashuRestoreTitle,backupJson,backupJsonHint,pleaseEnterBackup,restoringBackup, andrestoreSuccess. These keys must be added with Chinese translations to prevent English fallback text in the generated localization code.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ndk_flutter/lib/l10n/app_zh.arb` around lines 1 - 377, The Chinese ARB is missing several Cashu backup/restore localization keys which causes English fallbacks; add the following keys with Chinese translations into app_zh.arb: backup, restore, cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup, restoringBackup, and restoreSuccess (use the same key names as in the Russian locale and provide appropriate Chinese strings for each) so the generated localization includes Chinese variants for the backup/restore dialog.packages/ndk_flutter/lib/l10n/app_ru.arb (1)
1-377:⚠️ Potential issue | 🟠 MajorAdd missing ARB entries for Cashu backup/restore dialog strings (avoid English fallback)
packages/ndk_flutter/lib/l10n/app_ru.arbis missing keysbackup,restore,cashuBackupTitle,cashuBackupWarning,generatingBackup,copyBackup,backupCopiedToClipboard,cashuRestoreTitle,backupJson,backupJsonHint,pleaseEnterBackup,restoringBackup,restoreSuccess.packages/ndk_flutter/lib/l10n/app_localizations_ru.dartstill defines these getters, but their values are English (e.g.,cashuBackupTitle/generatingBackup/copyBackup/backupCopiedToClipboard/cashuRestoreTitle), so the Russian UI will show English in the backup/restore flow.- The same missing key set shows up across other non-
enpackages/ndk_flutter/lib/l10n/app_*.arbfiles (onlyapp_en.arbcontains them).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ndk_flutter/lib/l10n/app_ru.arb` around lines 1 - 377, The Russian ARB is missing the Cashu backup/restore localization keys (backup, restore, cashuBackupTitle, cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard, cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup, restoringBackup, restoreSuccess) which causes app_localizations_ru.dart getters to fall back to English; add these keys with Russian translations into packages/ndk_flutter/lib/l10n/app_ru.arb (matching the same keys present in app_en.arb) so the getters in app_localizations_ru.dart return localized Russian strings instead of English.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/ndk_flutter/lib/l10n/app_ru.arb`:
- Around line 1-377: The Russian ARB is missing the Cashu backup/restore
localization keys (backup, restore, cashuBackupTitle, cashuBackupWarning,
generatingBackup, copyBackup, backupCopiedToClipboard, cashuRestoreTitle,
backupJson, backupJsonHint, pleaseEnterBackup, restoringBackup, restoreSuccess)
which causes app_localizations_ru.dart getters to fall back to English; add
these keys with Russian translations into
packages/ndk_flutter/lib/l10n/app_ru.arb (matching the same keys present in
app_en.arb) so the getters in app_localizations_ru.dart return localized Russian
strings instead of English.
In `@packages/ndk_flutter/lib/l10n/app_zh.arb`:
- Around line 1-377: The Chinese ARB is missing several Cashu backup/restore
localization keys which causes English fallbacks; add the following keys with
Chinese translations into app_zh.arb: backup, restore, cashuBackupTitle,
cashuBackupWarning, generatingBackup, copyBackup, backupCopiedToClipboard,
cashuRestoreTitle, backupJson, backupJsonHint, pleaseEnterBackup,
restoringBackup, and restoreSuccess (use the same key names as in the Russian
locale and provide appropriate Chinese strings for each) so the generated
localization includes Chinese variants for the backup/restore dialog.
In `@packages/ndk/lib/domain_layer/usecases/cashu/cashu_cache_decorator.dart`:
- Around line 168-178: The setDerivationCounter method currently calls
_delegate.setCashuSecretCounter directly and bypasses the mutex; wrap the
delegate call inside _mutex.synchronized (same pattern used in
setCashuSecretCounter) to ensure serialized access. Inside setDerivationCounter,
call _mutex.synchronized(() async { await
_delegate.setCashuSecretCounter(mintUrl: mintUrl, keysetId: keysetId, counter:
counter); }); keeping the same parameter mapping and error propagation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f23aa9e7-04e7-49f5-a145-2816ac3768f3
📒 Files selected for processing (31)
packages/ndk/lib/data_layer/models/wallet_transaction_model.dartpackages/ndk/lib/domain_layer/usecases/cashu/cashu.dartpackages/ndk/lib/domain_layer/usecases/cashu/cashu_cache_decorator.dartpackages/ndk/lib/domain_layer/usecases/cashu/cashu_export_import.dartpackages/ndk/lib/ndk.dartpackages/ndk/test/cashu/cashu_import_export_test.dartpackages/ndk_flutter/lib/l10n/app_de.arbpackages/ndk_flutter/lib/l10n/app_en.arbpackages/ndk_flutter/lib/l10n/app_es.arbpackages/ndk_flutter/lib/l10n/app_fi.arbpackages/ndk_flutter/lib/l10n/app_fr.arbpackages/ndk_flutter/lib/l10n/app_it.arbpackages/ndk_flutter/lib/l10n/app_ja.arbpackages/ndk_flutter/lib/l10n/app_localizations.dartpackages/ndk_flutter/lib/l10n/app_localizations_de.dartpackages/ndk_flutter/lib/l10n/app_localizations_en.dartpackages/ndk_flutter/lib/l10n/app_localizations_es.dartpackages/ndk_flutter/lib/l10n/app_localizations_fi.dartpackages/ndk_flutter/lib/l10n/app_localizations_fr.dartpackages/ndk_flutter/lib/l10n/app_localizations_it.dartpackages/ndk_flutter/lib/l10n/app_localizations_ja.dartpackages/ndk_flutter/lib/l10n/app_localizations_pl.dartpackages/ndk_flutter/lib/l10n/app_localizations_pt.dartpackages/ndk_flutter/lib/l10n/app_localizations_ru.dartpackages/ndk_flutter/lib/l10n/app_localizations_zh.dartpackages/ndk_flutter/lib/l10n/app_pl.arbpackages/ndk_flutter/lib/l10n/app_pt.arbpackages/ndk_flutter/lib/l10n/app_pt_BR.arbpackages/ndk_flutter/lib/l10n/app_ru.arbpackages/ndk_flutter/lib/l10n/app_zh.arbpackages/ndk_flutter/lib/widgets/wallets/wallet_action_dialogs.dart
✅ Files skipped from review due to trivial changes (9)
- packages/ndk/test/cashu/cashu_import_export_test.dart
- packages/ndk/lib/ndk.dart
- packages/ndk_flutter/lib/l10n/app_de.arb
- packages/ndk_flutter/lib/l10n/app_pt.arb
- packages/ndk_flutter/lib/l10n/app_es.arb
- packages/ndk_flutter/lib/l10n/app_fr.arb
- packages/ndk_flutter/lib/l10n/app_en.arb
- packages/ndk_flutter/lib/l10n/app_it.arb
- packages/ndk_flutter/lib/l10n/app_localizations_fr.dart
🚧 Files skipped from review as they are similar to previous changes (15)
- packages/ndk_flutter/lib/l10n/app_fi.arb
- packages/ndk_flutter/lib/l10n/app_pl.arb
- packages/ndk_flutter/lib/l10n/app_pt_BR.arb
- packages/ndk_flutter/lib/l10n/app_ja.arb
- packages/ndk_flutter/lib/l10n/app_localizations_en.dart
- packages/ndk_flutter/lib/l10n/app_localizations_it.dart
- packages/ndk_flutter/lib/l10n/app_localizations_ja.dart
- packages/ndk_flutter/lib/l10n/app_localizations_zh.dart
- packages/ndk_flutter/lib/l10n/app_localizations_de.dart
- packages/ndk_flutter/lib/l10n/app_localizations_fi.dart
- packages/ndk_flutter/lib/l10n/app_localizations.dart
- packages/ndk_flutter/lib/l10n/app_localizations_pl.dart
- packages/ndk_flutter/lib/l10n/app_localizations_es.dart
- packages/ndk_flutter/lib/l10n/app_localizations_pt.dart
- packages/ndk_flutter/lib/widgets/wallets/wallet_action_dialogs.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Localization
Tests