Update all dependencies (including nom 7.1.0) and update code base by Titaniumtown · Pull Request #27 · rekka/meval-rs

Titaniumtown · 2022-02-16T15:52:09Z

(Includes an updated version of #22 and #26)
This PR updates all dependencies (including nom, using updated fixes from #22) and fixes depreciation warnings (from #26). I hope this PR can serve as a meta PR of sorts as it seems development has ceased on this project.

based on work from: rekka#22

rekka · 2022-02-21T09:44:15Z

Thank you for the pull request. I currently am a bit short on time so it might take me a week or two to review this.

The development ceased since the crate does what I need it to do and I haven't had any issues using it in my project. I also forgot how to publish updates to crates.io in the meantime. :)

I have a few questions about this pull request:

Is there a reason why the update to nom 7 is necessary? Nom 1 seems to work fine.
Do the deprecation warnings show up when this crate is used as a dependency?
Why is it useful to specify the precise current version of serde? Isn't serde = { version = "1", optional = true } fine? Is there an anticipation that a minor version bump will break compatibility?

Titaniumtown · 2022-02-22T00:01:29Z

Is there a reason why the update to nom 7 is necessary? Nom 1 seems to work fine.

I mean, doesn't hurt not to update it.

Do the deprecation warnings show up when this crate is used as a dependency?

I don't think so? I can't remember.

Why is it useful to specify the precise current version of serde? Isn't serde = { version = "1", optional = true } fine? Is there an anticipation that a minor version bump will break compatibility?

I was not aware it works that way. I'll revert that change later.

MiscStuff839 · 2022-02-23T16:20:21Z

This PR updates all dependencies (including nom, using updated fixes from #22) and fixes depreciation warnings (from #22).

you mean depracation warnings by #26

MiscStuff839 · 2022-02-23T16:31:17Z

Do the deprecation warnings show up when this crate is used as a dependency?

No it only appears when compiling the source but mainly the operators and the try! macro were depracated for more information see #26 (I refer to it everywhere because it is my first contribution to open-source so just ignore and pls let me enjoy in my bubble for a bit. thank you)

Titaniumtown · 2022-02-24T14:57:51Z

This PR updates all dependencies (including nom, using updated fixes from #22) and fixes depreciation warnings (from #22).

you mean depracation warnings by #26

Whoops! Typo.

Titaniumtown · 2022-03-04T23:11:04Z

@rekka Anything blocking this PR? Just wondering.

MiscStuff839 · 2022-03-07T06:25:06Z

There do not seem to be any merge conflicts but why is the CI not running?

Titaniumtown · 2022-03-07T14:48:43Z

No clue.

MiscStuff839

Is there a reason that the values should not be constants seeing as they are hardcoded anyway?

Titaniumtown · 2022-03-25T00:27:10Z

Is there a reason that the values should not be constants seeing as they are hardcoded anyway?

Do elaborate on what values you're referring to.

MiscStuff839 · 2022-04-07T11:16:19Z

@rekka any issue with the PR?

MiscStuff839 · 2022-04-09T10:52:59Z

Is there a reason that the values should not be constants seeing as they are hardcoded anyway?

Do elaborate on what values you're referring to.

Never mind after testing I understood.

emixa-d · 2022-08-04T19:05:45Z

I tried out these patches but I'm getting some test failures:

starting phase `check'

running 13 tests
test expr::tests::hash_context ... ok
test expr::tests::test_builtins ... ok
test expr::tests::test_eval ... ok
test extra_math::tests::test_factorial ... ok
test expr::tests::test_eval_func_ctx ... ok
test shunting_yard::tests::test_to_rpn ... ok
test expr::tests::test_bind ... ok
test tokenizer::tests::test_func ... ok
test tokenizer::tests::test_var ... ok
test tokenizer::tests::test_tokenize ... ok
test tokenizer::tests::it_works ... FAILED
test tokenizer::tests::test_lexpr ... FAILED
test tokenizer::tests::test_number ... FAILED

failures:

---- tokenizer::tests::it_works stdout ----
thread 'tokenizer::tests::it_works' panicked at 'assertion failed: `(left == right)`
  left: `Err(Error(("+1.34e2", OneOf)))`,
 right: `Ok(("", Number(134.0)))`', src/tokenizer.rs:357:9
stack backtrace:
   0:     0x7ffff7e3361c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h7767eb774a4d4f42
   1:     0x7ffff7ec4bfc - core::fmt::write::hf3fb1fb91b38bb59
   2:     0x7ffff7e01bd5 - <unknown>
   3:     0x7ffff7e151bb - <unknown>
   4:     0x7ffff7e14d61 - <unknown>
   5:     0x7ffff7e1598b - std::panicking::rust_panic_with_hook::h19ec2b337ecb8872
   6:     0x7ffff7e34450 - <unknown>
   7:     0x7ffff7e33744 - <unknown>
   8:     0x7ffff7e15402 - rust_begin_unwind
   9:     0x7ffff7df5681 - core::panicking::panic_fmt::h964c785332841a13
  10:     0x7ffff7ea87f8 - core::panicking::assert_failed_inner::h45014c2f24de47a0
  11:     0x55555555b20b - core::panicking::assert_failed::hc09dc98f5734ad42
                               at /tmp/guix-build-rust-1.57.0.drv-0/rustc-1.57.0-src/library/core/src/panicking.rs:138:5
  12:     0x55555556c890 - meval::tokenizer::tests::it_works::h257179fc5ac459eb
                               at /tmp/guix-build-rust-meval-0.2.0.drv-0/source/src/tokenizer.rs:357:9
  13:     0x7ffff7f58293 - <unknown>
  14:     0x7ffff7f5845b - <unknown>
  15:     0x7ffff7f6df75 - <unknown>
  16:     0x7ffff7f66d0f - <unknown>
  17:     0x7ffff7e250e3 - <unknown>
  18:     0x7ffff7a58d7e - <unknown>
  19:     0x7ffff7b66eff - clone
  20:                0x0 - <unknown>

---- tokenizer::tests::test_lexpr stdout ----
thread 'tokenizer::tests::test_lexpr' panicked at 'assertion failed: `(left == right)`
  left: `Err(Error(("a", OneOf)))`,
 right: `Err(Error(("a", Float)))`', src/tokenizer.rs:378:9
stack backtrace:
   0:     0x7ffff7e3361c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h7767eb774a4d4f42
   1:     0x7ffff7ec4bfc - core::fmt::write::hf3fb1fb91b38bb59
   2:     0x7ffff7e01bd5 - <unknown>
   3:     0x7ffff7e151bb - <unknown>
   4:     0x7ffff7e14d61 - <unknown>
   5:     0x7ffff7e1598b - std::panicking::rust_panic_with_hook::h19ec2b337ecb8872
   6:     0x7ffff7e34450 - <unknown>
   7:     0x7ffff7e33744 - <unknown>
   8:     0x7ffff7e15402 - rust_begin_unwind
   9:     0x7ffff7df5681 - core::panicking::panic_fmt::h964c785332841a13
  10:     0x7ffff7ea87f8 - core::panicking::assert_failed_inner::h45014c2f24de47a0
  11:     0x55555555b20b - core::panicking::assert_failed::hc09dc98f5734ad42
                               at /tmp/guix-build-rust-1.57.0.drv-0/rustc-1.57.0-src/library/core/src/panicking.rs:138:5
  12:     0x55555556d28d - meval::tokenizer::tests::test_lexpr::h37dbe191a8f6f566
                               at /tmp/guix-build-rust-meval-0.2.0.drv-0/source/src/tokenizer.rs:378:9
  13:     0x7ffff7f58293 - <unknown>
  14:     0x7ffff7f5845b - <unknown>
  15:     0x7ffff7f6df75 - <unknown>
  16:     0x7ffff7f66d0f - <unknown>
  17:     0x7ffff7e250e3 - <unknown>
  18:     0x7ffff7a58d7e - <unknown>
  19:     0x7ffff7b66eff - clone
  20:                0x0 - <unknown>

---- tokenizer::tests::test_number stdout ----
thread 'tokenizer::tests::test_number' panicked at 'assertion failed: `(left == right)`
  left: `Err(Failure(("1E", Float)))`,
 right: `Err(Error(("E", Eof)))`', src/tokenizer.rs:460:9
stack backtrace:
   0:     0x7ffff7e3361c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h7767eb774a4d4f42
   1:     0x7ffff7ec4bfc - core::fmt::write::hf3fb1fb91b38bb59
   2:     0x7ffff7e01bd5 - <unknown>
   3:     0x7ffff7e151bb - <unknown>
   4:     0x7ffff7e14d61 - <unknown>
   5:     0x7ffff7e1598b - std::panicking::rust_panic_with_hook::h19ec2b337ecb8872
   6:     0x7ffff7e34450 - <unknown>
   7:     0x7ffff7e33744 - <unknown>
   8:     0x7ffff7e15402 - rust_begin_unwind
   9:     0x7ffff7df5681 - core::panicking::panic_fmt::h964c785332841a13
  10:     0x7ffff7ea87f8 - core::panicking::assert_failed_inner::h45014c2f24de47a0
  11:     0x55555555b20b - core::panicking::assert_failed::hc09dc98f5734ad42
                               at /tmp/guix-build-rust-1.57.0.drv-0/rustc-1.57.0-src/library/core/src/panicking.rs:138:5
  12:     0x55555556f30a - meval::tokenizer::tests::test_number::h9f3aa1bd07760254
                               at /tmp/guix-build-rust-meval-0.2.0.drv-0/source/src/tokenizer.rs:460:9
  13:     0x7ffff7f58293 - <unknown>
  14:     0x7ffff7f5845b - <unknown>
  15:     0x7ffff7f6df75 - <unknown>
  16:     0x7ffff7f66d0f - <unknown>
  17:     0x7ffff7e250e3 - <unknown>
  18:     0x7ffff7a58d7e - <unknown>
  19:     0x7ffff7b66eff - clone
  20:                0x0 - <unknown>


failures:
    tokenizer::tests::it_works
    tokenizer::tests::test_lexpr
    tokenizer::tests::test_number

test result: FAILED. 10 passed; 3 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

In case it matters, this is with rust 1.56, rust-serde-json 1.0.74, rust-serde-test 1.0.113, rust-fnv 1.0.6, rust-nom 7.1.1 and rust-serde 1.0.133.

hydra · 2023-01-13T11:54:11Z

Any update on this? I'm trying to clear-up all the warnings in a project I'm working on and the 'meval' crate is a dependency of the 'textplots' crate, and thus I'm seeing a bunch of warnings relating to the very old nom 1.2.4 dependency so it would be excellent if this crate could be updated as per this PR.

antimora · 2023-05-31T22:59:17Z

@rekka Can you please merge this update and push a new release? We are getting a build warning telling that the future version of Rust will be rejected:

    Finished dev [unoptimized + debuginfo] target(s) in 0.30s
warning: the following packages contain code that will be rejected by a future version of Rust: nom v1.2.4

Keavon · 2024-03-27T23:05:27Z

@rekka I'd really appreciate if you could take a moment to merge this and deploy a new release. It causes warnings, and will eventually break entirely, because the old version of nom won't be valid Rust code in the future. An update would help us avoid this future problem and stop having to see the warning every time. Thank you!

ognevny · 2024-07-23T18:35:33Z

I'd really appreciate if you could take a moment to merge this and deploy a new release. It causes warnings, and will eventually break entirely, because the old version of nom won't be valid Rust code in the future. An update would help us avoid this future problem and stop having to see the warning every time. Thank you!

for now you all can only add [patch.crates-io] in manifest with this fork. personally I don't believe that anything will be changed in future ;(

Simon Gardling and others added 8 commits February 16, 2022 10:40

update all dependencies (except for nom)

b460b58

removed depracation warnings and substituted

978dbcf

bump even more dependencies

9cd8b3d

nom 7.1.0

595ea70

based on work from: rekka#22

clippy

f888f42

rustfmt

ad90ef7

add 'log' function (does the same thing as log10)

f6b868d

update README.md

00cd188

Titaniumtown force-pushed the master branch from 7e3dd78 to 00cd188 Compare February 17, 2022 16:28

don't specify specific serde version

115b1ef

fix variable naming

6bf579f

MiscStuff839 reviewed Mar 21, 2022

View reviewed changes

hydra mentioned this pull request Jan 13, 2023

Make dependencies that are only required to build the tool optional. loony-bean/textplots-rs#40

Merged

adri326 mentioned this pull request Jun 10, 2023

lib-version only without structopt dependency loony-bean/textplots-rs#36

Closed

asukaminato0721 mentioned this pull request Aug 29, 2023

warning in compile open-spaced-repetition/fsrs-rs#41

Closed

Conversation

Titaniumtown commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rekka commented Feb 21, 2022

Uh oh!

Titaniumtown commented Feb 22, 2022

Uh oh!

MiscStuff839 commented Feb 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MiscStuff839 commented Feb 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Titaniumtown commented Feb 24, 2022

Uh oh!

Titaniumtown commented Mar 4, 2022

Uh oh!

MiscStuff839 commented Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Titaniumtown commented Mar 7, 2022

Uh oh!

MiscStuff839 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Titaniumtown commented Mar 25, 2022

Uh oh!

MiscStuff839 commented Apr 7, 2022

Uh oh!

MiscStuff839 commented Apr 9, 2022

Uh oh!

emixa-d commented Aug 4, 2022

Uh oh!

hydra commented Jan 13, 2023

Uh oh!

antimora commented May 31, 2023

Uh oh!

Keavon commented Mar 27, 2024

Uh oh!

ognevny commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Titaniumtown commented Feb 16, 2022 •

edited

Loading

MiscStuff839 commented Feb 23, 2022 •

edited

Loading

MiscStuff839 commented Feb 23, 2022 •

edited

Loading

MiscStuff839 commented Mar 7, 2022 •

edited

Loading

MiscStuff839 left a comment •

edited

Loading