Add app version to TizenTube Settings entry (build: enable JSON imports)#375
Open
KrX3D wants to merge 6 commits intoreisxd:mainfrom
Open
Add app version to TizenTube Settings entry (build: enable JSON imports)#375KrX3D wants to merge 6 commits intoreisxd:mainfrom
KrX3D wants to merge 6 commits intoreisxd:mainfrom
Conversation
…d_version_in_settings
…ttings sync: upstream reisxd/TizenTube main (36 commits)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the Settings UX by showing the current app version directly in the TizenTube Settings entry.
The previous subtitle text (“Open TizenTube Settings”) was a bit redundant, because the page title/button already communicates that selecting it opens the settings page. Replacing it with the version makes the entry more useful for debugging and support.
Picture
Changes
UI:
mods/ui/customYTSettings.jsVersion: <package.json version>(e.g.Version: 1.12.7)package.jsonBuild:
mods/rollup.config.js@rollup/plugin-jsonso Rollup can importpackage.jsonDependencies:
mods/package.json@rollup/plugin-json(and lockfile updated accordingly)Notes