Skip to content

feat: add scroll target prop #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dskvr91 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add scroll target prop #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dist/vue-virtual-scroller.esm.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/vue-virtual-scroller.esm.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/vue-virtual-scroller.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/vue-virtual-scroller.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 10 additions & 1 deletion dist/vue-virtual-scroller.umd.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/vue-virtual-scroller.umd.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vue-virtual-scroller",
"name": "@regru/vue-virtual-scroller",
"description": "Smooth scrolling for any amount of data",
"version": "1.0.10",
"version": "1.1.0",
"author": {
"name": "Guillaume Chau",
"email": "guillaume.b.chau@gmail.com"
Expand Down
10 changes: 10 additions & 0 deletions src/components/RecycleScroller.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ export default {
type: Boolean,
default: false,
},

scrollTarget: {
type: [HTMLDocument, HTMLElement],
default: null,
},
},

data () {
Expand Down Expand Up @@ -491,6 +496,11 @@ export default {
},

getListenerTarget () {
// Apply custom listener target
if (this.scrollTarget) {
return this.scrollTarget
}

let target = ScrollParent(this.$el)
// Fix global scroll target for Chrome and Safari
if (window.document && (target === window.document.documentElement || target === window.document.body)) {
Expand Down