Skip to content

Increase case study click area in navbar#6529

Merged
Alek99 merged 4 commits into
mainfrom
carlos/update-customer-navbar-link
May 20, 2026
Merged

Increase case study click area in navbar#6529
Alek99 merged 4 commits into
mainfrom
carlos/update-customer-navbar-link

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested review from a team and Alek99 as code owners May 19, 2026 09:15
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 19, 2026

Greptile Summary

This PR widens the clickable area of the case study card in the Solutions navbar dropdown by replacing the individual title anchor with a full-area cover-link (absolute inset-0). The "Book a Demo" dialog button is elevated with relative z-10 so it remains interactive above the overlay, and the parent container gains the group class to drive hover-colour transitions on the title text.

  • marketing_navbar.py: case_studies_column() refactored — title <a> demoted to <span>, a new empty absolute inset-0 anchor covers the whole card, divider and demo-form wrapper both get relative z-10 to sit above the overlay.
  • bun.lock / package.json: Routine dependency bumps (react 19.2.6, react-router 7.15.0, lucide-react 1.14.0, plotly.js 3.5.1) and addition of tailwindcss-scroll-mask.

Confidence Score: 4/5

Safe to merge — the cover-link pattern is implemented correctly with proper z-index layering to keep the demo dialog interactive; the only gap is a missing accessible name on the overlay anchor.

The z-index stacking (demo wrapper at z-10, overlay anchor at auto/0) correctly ensures the Book a Demo button remains clickable. The one open issue is that the new empty overlay anchor carries no text or aria-label, so assistive technologies will announce an unnamed link.

packages/reflex-site-shared/src/reflex_site_shared/views/marketing_navbar.py — specifically the new empty overlay anchor at the bottom of case_studies_column().

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/views/marketing_navbar.py Refactors case_studies_column() to use a cover-link pattern: the case study title is demoted from to , a full-area absolute inset-0 anchor replaces it, and the Book a Demo wrapper gets relative z-10 so it stays interactive above the overlay. The overlay anchor is empty with no aria-label.
docs/app/reflex.lock/bun.lock Routine dependency version bumps: react/react-dom 19.2.5→19.2.6, react-router 7.14.1→7.15.0, lucide-react 1.8.0→1.14.0, plotly.js 3.5.0→3.5.1, isbot 5.1.39→5.1.40, and addition of tailwindcss-scroll-mask 2.0.0.
docs/app/reflex.lock/package.json Updates top-level dependency version pins to match the bun.lock bumps; no structural changes.

Reviews (1): Last reviewed commit: "Increase case study click area in navbar" | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 19, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing carlos/update-customer-navbar-link (097b5f9) with main (2aa49c5)

Open in CodSpeed

Alek99
Alek99 previously approved these changes May 20, 2026
@Alek99 Alek99 self-requested a review May 20, 2026 18:32
@Alek99 Alek99 merged commit 0ac41df into main May 20, 2026
70 checks passed
@Alek99 Alek99 deleted the carlos/update-customer-navbar-link branch May 20, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants