Replace Prettier with BiomeJS for webview client formatting#372
Merged
Conversation
Agent-Logs-Url: https://github.com/reflectometry/refl1d/sessions/9a4a1f10-7471-44ac-a1bc-a8da5788dacf Co-authored-by: bmaranville <686570+bmaranville@users.noreply.github.com>
Agent-Logs-Url: https://github.com/reflectometry/refl1d/sessions/9a4a1f10-7471-44ac-a1bc-a8da5788dacf Co-authored-by: bmaranville <686570+bmaranville@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace Prettier with BiomeJS for webview client
Replace Prettier with BiomeJS for webview client formatting
May 5, 2026
Member
|
This was somewhat a test if copilot could make a simple PR given clear instructions. I don't know that it saved me any time over doing it myself, as it missed a couple things and didn't follow directions exactly. (it went off-script in that it didn't copy the structure from the bumps PR exactly, so the pre-commit throws errors without having a biome.json both in the project and client root) |
bmaranville
approved these changes
May 5, 2026
pkienzle
approved these changes
May 6, 2026
glass-ships
reviewed
May 6, 2026
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the formatter migration from bumps/bumps#434 into this repo, scoped to the
refl1d/webview/clientfrontend.Config
refl1d/webview/client/biome.json— 2-space indent, 120-char line width, double quotes, ES5 trailing commas; linter disabled (ESLint owns that); schema pinned to2.4.13matching bumps PRrefl1d/webview/client/prettier.config.jspackage.json@biomejs/biome ^2.4.13prettier,eslint-plugin-prettier,@vue/eslint-config-prettier,eslint-config-prettier,@ianvs/prettier-plugin-sort-imports,prettier-plugin-css-order,prettier-plugin-jsdoceslint.config.jseslint-plugin-prettier/recommended,@vue/eslint-config-prettier,prettier/prettierrule, and"prettier"compat extendvue/html-indent,vue/max-attributes-per-line,vue/html-self-closing, etc.)CI (
.github/workflows/test-webview-client.yaml)test-formatjob runningbun run test:formatPre-commit (
.pre-commit-config.yaml)biome-formathook viabiomejs/pre-commit v0.6.1targeting.(vue|js|ts|…|json)filesFormatter-driven source changes
Biome reformatted ternary expressions in
DataView.vueandSimpleBuilder.vue(condition-first style vs. Prettier's value-first).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
biomejs.dev/usr/bin/curl curl -s -o /dev/null -w %{http_code} REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created from Copilot chat.