fix(ci): disable operator-injected lightspeed plugins to fix {{inherit}} resolution#4791
Open
gustavolira wants to merge 2 commits into
Open
fix(ci): disable operator-injected lightspeed plugins to fix {{inherit}} resolution#4791gustavolira wants to merge 2 commits into
gustavolira wants to merge 2 commits into
Conversation
…t}} resolution
The RHDH operator's lightspeed flavor (enabledByDefault: true) injects
lightspeed plugins from registry.access.redhat.com with {{inherit}}.
The catalog index only provides lightspeed from ghcr.io, so {{inherit}}
cannot resolve, causing InstallException in operator deployments.
Add disabled: true entries for both lightspeed plugins in values_showcase
and values_showcase-rbac. The operator merge gives priority to user
ConfigMap, so these override the flavor defaults and prevent the error.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
Member
Author
|
/test ? |
Member
Author
|
/test e2e-ocp-operator-nightly |
Review Summary by QodoDisable operator-injected lightspeed plugins to fix {{inherit}} resolution
WalkthroughsDescription• Disable operator-injected lightspeed plugins to prevent {{inherit}} resolution failures
• Add disabled entries for lightspeed plugins from registry.access.redhat.com
• Override RHDH operator flavor defaults in showcase value files
• Prevent InstallException errors in operator deployments (OCP, OSD-GCP, AKS, EKS, GKE)
Diagramflowchart LR
A["RHDH Operator<br/>lightspeed flavor<br/>enabledByDefault"] -->|injects plugins| B["registry.access.redhat.com<br/>lightspeed plugins<br/>with {{inherit}}"]
C["Catalog Index<br/>only has ghcr.io<br/>lightspeed"] -->|cannot resolve| B
B -->|causes| D["InstallException<br/>in deployments"]
E["values files<br/>disabled: true entries"] -->|override| A
E -->|prevent| D
File Changes1. .ci/pipelines/value_files/values_showcase-rbac.yaml
|
|
@gustavolira: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4791 +/- ##
===========================================
+ Coverage 40.88% 69.49% +28.60%
===========================================
Files 119 109 -10
Lines 2228 4710 +2482
Branches 562 537 -25
===========================================
+ Hits 911 3273 +2362
- Misses 1311 1437 +126
+ Partials 6 0 -6
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…eployment
The showcase-runtime namespace was deployed without a dynamic-plugins
ConfigMap, so the operator used only its built-in defaults (including
lightspeed with {{inherit}}). This caused install-dynamic-plugins to
fail with exit code 1, breaking all external database (Azure/RDS) tests.
Add config::create_dynamic_plugins_config call for the runtime namespace
and reference the ConfigMap in rhdh-start-runtime.yaml via
dynamicPluginsConfigMapName, matching the pattern of other operator CRs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
/test e2e-ocp-operator-nightly |
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enabledByDefault: true) injects lightspeed plugins fromregistry.access.redhat.comwith{{inherit}}quay.io/rhdh/plugin-catalog-index:1.10) only provides lightspeed fromghcr.io, notregistry.access.redhat.com{{inherit}}cannot resolve, causingInstallExceptionin all operator deployments (OCP, OSD-GCP, AKS, EKS, GKE)disabled: trueentries for both lightspeed plugins invalues_showcase.yamlandvalues_showcase-rbac.yamlto override the operator flavor defaultsRoot Cause
The operator merges its built-in flavor plugins with the user's ConfigMap, giving priority to user entries. Without explicit
disabled: trueentries in the values files, the operator-injected lightspeed plugins (fromregistry.access.redhat.com) attempt{{inherit}}resolution against the catalog index, which only contains lightspeed fromghcr.io. The URL prefix mismatch causes the resolution to fail.Fix
Add
disabled: trueentries in the base values files so the operator merge picks them up and prevents{{inherit}}resolution for these plugins. The entries are harmless for Helm deployments (filtered out bypre_merge_oci_disabled_statebefore any version resolution).Test plan
periodic-ci-redhat-developer-rhdh-main-e2e-osd-gcp-operator-nightlypasses🤖 Generated with Claude Code