Skip to content

DFBUGS-6865: Fix PVC leftover issue for non-discovered apps #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raaizik wants to merge 1 commit into
base: release-4.21
Choose a base branch
from
+11 −3
Open

DFBUGS-6865: Fix PVC leftover issue for non-discovered apps #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions internal/controller/volsync/vshandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3084,9 +3084,17 @@ func (v *VSHandler) checkLastSnapshotSyncStatus(lrs *volsyncv1alpha1.Replication
}

func (v *VSHandler) DisownVolSyncManagedPVC(pvc *corev1.PersistentVolumeClaim) error {
// TODO: Remove just the VRG ownerReference instead of blindly removing all ownerreferences.
// For now, this is fine, given that the VRG is the sole owner of the PVC after DR is enabled.
pvc.ObjectMeta.OwnerReferences = nil
// Remove only the VRG ownerReference, keeping VolSync resource (RS/RD) ownership
// This allows Kubernetes garbage collection to properly clean up PVCs when VolSync resources are deleted
newRefs := []metav1.OwnerReference{}

for _, ref := range pvc.OwnerReferences {
if ref.Kind != "VolumeReplicationGroup" {
newRefs = append(newRefs, ref)
}
}

pvc.ObjectMeta.OwnerReferences = newRefs
delete(pvc.Annotations, ACMAppSubDoNotDeleteAnnotation)

return v.client.Update(v.ctx, pvc)
Expand Down
Loading