Skip to content

DFBUGS-4843: Fix failover getting stuck due to early MaintenanceMode removal#723

Open
raaizik wants to merge 1 commit into
red-hat-storage:release-4.20from
raaizik:dfbugs_4756_fix_failover_stuck
Open

DFBUGS-4843: Fix failover getting stuck due to early MaintenanceMode removal#723
raaizik wants to merge 1 commit into
red-hat-storage:release-4.20from
raaizik:dfbugs_4756_fix_failover_stuck

Conversation

@raaizik
Copy link
Copy Markdown

@raaizik raaizik commented Feb 24, 2026

The drcluster_mmode controller now checks all failover DRPCs targeting the cluster and keeps MaintenanceMode active until ConditionAvailable is True for the current DRPC generation. This prevents premature resumption of RBD mirroring while VRG promotion is still failing (e.g. "failed to promote volume", no lastGroupSyncTime), which previously left some RBD workloads stuck in WaitForReadiness/Cleaning Up.

(cherry picked from commit c0f026e)

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raaizik

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raaizik raaizik changed the title DFBUGS-4756 Fix failover getting stuck due to early MaintenanceMode removal DFBUGS-4843: Fix failover getting stuck due to early MaintenanceMode removal Feb 26, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference jira/invalid-bug labels Feb 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 26, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com//browse/DFBUGS-4843), which is invalid:

  • expected the bug to target either version "odf-4.20.6." or "openshift-odf-4.20.6.", but it targets "odf-4.20.5" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

The drcluster_mmode controller now checks all failover DRPCs targeting the cluster and keeps MaintenanceMode active until ConditionAvailable is True for the current DRPC generation. This prevents premature resumption of RBD mirroring while VRG promotion is still failing (e.g. "failed to promote volume", no lastGroupSyncTime), which previously left some RBD workloads stuck in WaitForReadiness/Cleaning Up.

(cherry picked from commit c0f026e)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Copy link
Copy Markdown
Author

raaizik commented Feb 26, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 26, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com//browse/DFBUGS-4843), which is invalid:

  • expected the bug to target either version "odf-4.20.6." or "openshift-odf-4.20.6.", but it targets "odf-4.20.5" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Copy link
Copy Markdown
Author

raaizik commented Feb 26, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 26, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com//browse/DFBUGS-4843), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Copy link
Copy Markdown
Author

raaizik commented Feb 26, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 26, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com//browse/DFBUGS-4843), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Copy link
Copy Markdown
Author

raaizik commented Feb 26, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 26, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com//browse/DFBUGS-4843), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Copy link
Copy Markdown
Author

raaizik commented Mar 9, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 9, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com/browse/DFBUGS-4843), which is invalid:

  • expected the bug to target the "odf-4.20.6" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Copy link
Copy Markdown
Author

raaizik commented Mar 9, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 9, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com/browse/DFBUGS-4843), which is invalid:

  • expected the bug to target either version "odf-4.20.8." or "openshift-odf-4.20.8.", but it targets "odf-4.20.5" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Copy link
Copy Markdown
Author

raaizik commented Mar 9, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 9, 2026 •
edited by openshift-ci Bot
Loading

@raaizik: This pull request references [Jira Issue DFBUGS-4843](https://issues.redhat.com/browse/DFBUGS-4843), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.20.8) matches configured target version for branch (odf-4.20.8)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (ammahapa@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@raaizik
Fix failover getting stuck due to early MaintenanceMode removal
981e6a5 
The drcluster_mmode controller now checks all failover DRPCs targeting the
cluster and keeps MaintenanceMode active until ConditionAvailable is True
for the current DRPC generation. This prevents premature resumption of
RBD mirroring while VRG promotion is still failing (e.g. "failed to
promote volume", no lastGroupSyncTime), which previously left some
RBD workloads stuck in WaitForReadiness/Cleaning Up.

Signed-off-by: raaizik <132667934+raaizik@users.noreply.github.com>
(cherry picked from commit c0f026e)
@raaizik raaizik force-pushed the dfbugs_4756_fix_failover_stuck branch from 587146c to 981e6a5 Compare March 30, 2026 11:22
@raghavendra-talur
Copy link
Copy Markdown

raghavendra-talur commented May 13, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 13, 2026 •
edited by openshift-ci Bot
Loading

@raghavendra-talur: This pull request references [Jira Issue DFBUGS-4843](https://redhat.atlassian.net/browse/DFBUGS-4843), which is invalid:

  • expected the bug to target either version "odf-4.20.12." or "openshift-odf-4.20.12.", but it targets "odf-4.20.8" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShyamsundarR ShyamsundarR Awaiting requested review from ShyamsundarR ShyamsundarR is a code owner

@BenamarMk BenamarMk Awaiting requested review from BenamarMk BenamarMk is a code owner

Assignees

No one assigned

Labels

jira/invalid-bug jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raaizik @openshift-ci-robot @raghavendra-talur