Skip to content

DFBUGS-1778: Ensure Consistent Iteration Order by Using DRClusters Slice#484

Open
ELENAGER wants to merge 1 commit into
red-hat-storage:release-4.18from
ELENAGER:DFBUGS-1778_backport
Open

DFBUGS-1778: Ensure Consistent Iteration Order by Using DRClusters Slice#484
ELENAGER wants to merge 1 commit into
red-hat-storage:release-4.18from
ELENAGER:DFBUGS-1778_backport

Conversation

@ELENAGER
Copy link
Copy Markdown

Use the DRClusters slice instead of the map of queried VRGs to ensure a consistent iteration order. Since map iteration is unpredictable, even when the map contents remain the same. Additionally, DRClusters are known in advance and should be used instead of the queried clusters, as secrets are propagated to all DR clusters, not just the successfully queried ones.

Signed-off-by: Benamar Mekhissi bmekhiss@ibm.com
(cherry picked from commit e8e17e5)

Use the DRClusters slice instead of the map of queried VRGs to ensure a consistent
iteration order. Since map iteration is unpredictable, even when the map contents
remain the same. Additionally, DRClusters are known in advance and should be used
instead of the queried clusters, as secrets are propagated to all DR clusters,
not just the successfully queried ones.

Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
(cherry picked from commit e8e17e5)
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference jira/invalid-bug labels Mar 27, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 27, 2025

@ELENAGER: This pull request references [Jira Issue DFBUGS-1778](https://issues.redhat.com//browse/DFBUGS-1778), which is invalid:

  • expected the bug to target either version "odf-4.18.2." or "openshift-odf-4.18.2.", but it targets "odf-4.18.3" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Use the DRClusters slice instead of the map of queried VRGs to ensure a consistent iteration order. Since map iteration is unpredictable, even when the map contents remain the same. Additionally, DRClusters are known in advance and should be used instead of the queried clusters, as secrets are propagated to all DR clusters, not just the successfully queried ones.

Signed-off-by: Benamar Mekhissi bmekhiss@ibm.com
(cherry picked from commit e8e17e5)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenamarMk, ELENAGER

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShyamsundarR
Copy link
Copy Markdown

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 6, 2025

@ShyamsundarR: This pull request references [Jira Issue DFBUGS-1778](https://issues.redhat.com//browse/DFBUGS-1778), which is invalid:

  • expected the bug to target the "odf-4.18.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants