Skip to content

Include isNoProvisioner check to validateAdvancedSettingsStep #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Soundarya189r wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include isNoProvisioner check to validateAdvancedSettingsStep #2807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/odf/components/create-storage-system/footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ const validateAdvancedSettingsStep = (
advancedSettings: WizardState['advancedSettings'],
type: BackingStorageType,
nodeCount: number,
flexibleScaling: boolean
flexibleScaling: boolean,
deployment: DeploymentType,
isNoProvisioner: boolean
) => {
const {
useErasureCoding,
Expand All @@ -158,14 +160,19 @@ const validateAdvancedSettingsStep = (
forcefulDeploymentConfirmation,
} = advancedSettings;

const isMCG: boolean = deployment === DeploymentType.MCG;

const erasureCodingStepValid =
!useErasureCoding ||
!flexibleScaling ||
(nodeCount >= ERASURE_CODING_MIN_NODES && !!erasureCodingScheme);

const includeAdvancedSettingsStep =
!isMCG && (type === BackingStorageType.LOCAL_DEVICES || isNoProvisioner);

// The Next button is disabled only when no VolumeSnapshotClass is selected for MCG Standalone when automatic backup option enabled.
const hasForcefulDeploymentButNoConfirmation =
type === BackingStorageType.LOCAL_DEVICES &&
includeAdvancedSettingsStep &&
enableForcefulDeployment &&
!(forcefulDeploymentConfirmation?.trim() === 'CONFIRM');

Expand Down Expand Up @@ -277,7 +284,9 @@ const canJumpToNextStep = (
advancedSettings,
backingStorage.type,
nodes.length,
flexibleScaling
flexibleScaling,
backingStorage.deployment,
isNoProvisioner
);
case StepsName(t)[Steps.CreateStorageClass]:
return (
Expand Down
Loading