Fix missing external system name#2798
Conversation
Signed-off-by: Timothy Asir Jeyasingh <tim.gluster@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
bipuladh
left a comment
bipuladh
left a comment
There was a problem hiding this comment.
Please create a different header for Storage Area Network and put it there not under IBM Scale. Please consult UX team also for this bug.
| const getIBMScaleExternalSystemNames = ( | ||
| remoteClusters: RemoteClusterKind[] = [], | ||
| sanClusters: ClusterKind[] = [], | ||
| gpfsClusterNameFromDaemon?: string | ||
| ): string[] => { | ||
| const remoteNames = remoteClusters.map((c) => getName(c)); | ||
| const sanNames = sanClusters.map((c) => { | ||
| if (sanClusters.length === 1 && gpfsClusterNameFromDaemon) { | ||
| return gpfsClusterNameFromDaemon; | ||
| } | ||
| const crName = getName(c); | ||
| if (sanClusters.length === 1 && crName === IBM_SCALE_LOCAL_CLUSTER_NAME) { | ||
| return SAN_STORAGE_SYSTEM_NAME; | ||
| } | ||
| return crName; | ||
| }); | ||
| return [...remoteNames, ...sanNames]; | ||
| }; |
There was a problem hiding this comment.
SAN storage and scale are two different resources. Why are we showing it under the same header?
2 participants
https://redhat.atlassian.net/browse/DFBUGS-5324