StorageClass dropdown shows provisioner-based classes in TNF - #2753
Conversation
|
/test odf-console-e2e-aws |
|
/retest-required |
| secondaryTextGenerator={getStorageClassDescription} | ||
| initialSelection={getInitialSelection} | ||
| filterResource={filterResource} | ||
| {...(!isTNFEnabled && { initialSelection: getInitialSelection })} |
There was a problem hiding this comment.
why we need to make initialSelection as optional ??
| {...(!isTNFEnabled && { initialSelection: getInitialSelection })} | |
| initialSelection={getInitialSelection} |
|
|
||
| const filterResource = React.useCallback( | ||
| (sc: StorageClassResourceKind) => { | ||
| if (!isTNFEnabled) return true; |
There was a problem hiding this comment.
so for TNF enabled we only use NO_PROVISIONER?
There was a problem hiding this comment.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SanjalKatiyar, Soundarya189r The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.22 |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8ff5238
into
red-hat-storage:master
|
@SanjalKatiyar: new pull request created: #2806 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
https://redhat.atlassian.net/browse/DFBUGS-6344