S3 Vector Text changes#2738
Conversation
|
| "A unique name to identify and manage this protection.": "A unique name to identify and manage this protection.", | ||
| "A unique name within this vector bucket.": "A unique name within this vector bucket.", | ||
| "A vector bucket stores vector indexes for semantic search and similar workloads. You can create one with an Object Bucket Claim or directly through the S3 Vectors API.": "A vector bucket stores vector indexes for semantic search and similar workloads. You can create one with an Object Bucket Claim or directly through the S3 Vectors API.", | ||
| "A vector bucket is a cloud storage container that organizes and manages vector datasets (indexes), allowing users to store, retrieve and control access to data efficiently.": "A vector bucket is a cloud storage container that organizes and manages vector datasets (indexes), allowing users to store, retrieve and control access to data efficiently.", |
There was a problem hiding this comment.
| "A vector bucket is a cloud storage container that organizes and manages vector datasets (indexes), allowing users to store, retrieve and control access to data efficiently.": "A vector bucket is a cloud storage container that organizes and manages vector datasets (indexes), allowing users to store, retrieve and control access to data efficiently.", | |
| "A vector bucket is a storage container that organizes and manages vector datasets (indexes), allowing users to store, retrieve and control access to data efficiently.": "A vector bucket is a storage container that organizes and manages vector datasets (indexes), allowing users to store, retrieve and control access to data efficiently.", |
| <TextInput | ||
| id="vector-bucket-subpath-obc" | ||
| type="text" | ||
| placeholder="Enter a valid unix path" |
| <TextInput | ||
| id="vector-bucket-subpath-s3" | ||
| type="text" | ||
| placeholder="Enter a valid unix path" |
| title={t('Buckets')} | ||
| helpText={t('View and manage your vector buckets')} |
There was a problem hiding this comment.
what do we show for general S3 ?
both places should match, right ?
There was a problem hiding this comment.
We have this helpText={t('Browse, upload, and manage objects in buckets.')} for S3
@SanjalKatiyar
| <Label color="green">{t('S3 Vector')}</Label> | ||
| </Td> |
There was a problem hiding this comment.
why ??
we are already in S3 vector tab, why we need this column ?
There was a problem hiding this comment.
also, we should create a new bug and remove "Storage endpoint" column from General S3 table as well... that's redundant as well...
There was a problem hiding this comment.
got it, reverted, I will also raise a bug for S3
Soundarya189r
force-pushed
the
S3VectorTextUpdates
branch
from
c5576c9 to
df84b79
Compare
|
/approve |
|
/cherry-pick release-4.22 |
|
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/test odf-console-e2e-aws |
Soundarya189r
force-pushed
the
S3VectorTextUpdates
branch
from
df84b79 to
94f0549
Compare
|
/cherry-pick release-4.22 |
|
@Soundarya189r: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
Soundarya189r
force-pushed
the
S3VectorTextUpdates
branch
from
94f0549 to
f29e364
Compare
Soundarya189r
force-pushed
the
S3VectorTextUpdates
branch
from
f29e364 to
44e9833
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, SanjalKatiyar, Soundarya189r The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit a682e41
into
red-hat-storage:master
|
@Soundarya189r: new pull request created: #2804 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Figma : https://www.figma.com/design/afiVRYwhu4oVZdr4vaQINB/-4.22--MCG--UI--Missing-the-bucketType-selection-in-the-Create-ObjectBucketClaim?node-id=1-6&p=f&t=nB8QrOxBcQ3WNZlX-0
Updated the S3 Vectors content to match Figma
https://redhat.atlassian.net/browse/DFBUGS-6729