Compress CFrames using axis-angle representation#52
Merged
Conversation
sasial-dev
requested changes
Jan 4, 2024
sasial-dev
left a comment
Collaborator
There was a problem hiding this comment.
As discussed on Discord:
sasial-dev
requested changes
Jan 4, 2024
sasial-dev
left a comment
Collaborator
There was a problem hiding this comment.
Some initial comments
Contributor
Author
|
adding docs don't merge yet |
jackhexed
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effectively halves the size of CFrames from 12 f32s down to 6 f32s.
Does not deal with non-orthogonal CFrames but this is not really a big issue as discussed in the discord channel.
EDIT: For future readers, I'll explain the reasoning behind this.
Please review harshly, I am still not super fluent with Rust so I don't know the common patterns and what good, clean, Rust code looks like.
Credits to @aidan-epperly for the idea of using axis-angle representation to compress the rotation data, as well as for giving advice on implementation and possible edge cases.