VPAAMP-294: Add L1 regression test CheckEncryptedHeaders_RetuneInSinglePipelineMode#1457
Open
pstroffolino wants to merge 1 commit into
Open
VPAAMP-294: Add L1 regression test CheckEncryptedHeaders_RetuneInSinglePipelineMode#1457pstroffolino wants to merge 1 commit into
pstroffolino wants to merge 1 commit into
Conversation
…lePipelineMode Exercise the retune scenario where DeactivatePlayer(stop=true) removes the player from mActiveGstPlayersMap but mGstPlayer is retained, then a second CreateStreamSink takes the reuse branch and does not re-insert the player into mActiveGstPlayersMap. The old VPAAMP-214 guard would have silently dropped SetEncryptedHeaders in this state. The VPAAMP-294 fix removes that guard; this test verifies the fix by asserting SetEncryptedAamp is called correctly on both the first tune and retune.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Exercise the retune scenario where DeactivatePlayer(stop=true) removes the player from mActiveGstPlayersMap but mGstPlayer is retained, then a second CreateStreamSink takes the reuse branch and does not re-insert the player into mActiveGstPlayersMap. The old VPAAMP-214 guard would have silently dropped SetEncryptedHeaders in this state. The VPAAMP-294 fix removes that guard; this test verifies the fix by asserting SetEncryptedAamp is called correctly on both the first tune and retune.