VPAAMP-334: change non-error informational logs from ERR to MIL level#1450
Open
pstroffolino wants to merge 2 commits into
Open
VPAAMP-334: change non-error informational logs from ERR to MIL level#1450pstroffolino wants to merge 2 commits into
pstroffolino wants to merge 2 commits into
Conversation
Function-entry and success-path MW_LOG_ERR calls in ClearKeyHelper, WidevineDrmHelper, and SecManagerThunder (ShowWatermark, CreateWatermark, DeleteWatermark) replaced with MW_LOG_MIL to avoid misleading triage engineers. Genuine failure-path ERR logs are unchanged.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts misleading error-level logging for non-error function-entry/success-path events in DRM helper creation and Content Security Manager watermark operations, aligning log severity with operational intent.
Changes:
- Replaces selected
MW_LOG_ERRcalls withMW_LOG_MIL. - Keeps existing failure-path
MW_LOG_ERRcalls unchanged. - Applies the logging-level changes in ClearKey, Widevine, and watermark-related SecManagerThunder flows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
middleware/externals/contentsecuritymanager/SecManagerThunder.cpp |
Downgrades informational watermark operation entry logs from error to milestone. |
middleware/drm/helper/WidevineDrmHelper.cpp |
Changes successful Widevine helper creation logging from error to milestone. |
middleware/drm/helper/ClearKeyHelper.cpp |
Changes ClearKey helper creation logging from error to milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change: Function-entry and success-path MW_LOG_ERR calls in ClearKeyHelper, WidevineDrmHelper, and SecManagerThunder (ShowWatermark, CreateWatermark, DeleteWatermark) replaced with MW_LOG_MIL to avoid misleading triage engineers. Genuine failure-path ERR logs are unchanged.