Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPAAMP-163: Latency is fluctuating during normal playback in Linear/SLE assets #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev_sprint_25_2
Are you sure you want to change the base?
VPAAMP-163: Latency is fluctuating during normal playback in Linear/SLE assets #1412
Changes from 4 commits
6ab0dbbd3bb153210edb806f154ca7cfa64cd37dddFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback and #1412 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in cd37ddd. Changed
playbackOffsetFromWindowStartMsfromreportFormattedCurrPos - (culledSeconds*1000.0)(mixed coordinate spaces) toposition - (culledSeconds * 1000.0)— both in the same raw (unadjusted) space. Usingpositiondirectly (rather thanreportFormattedCurrPos - start) also avoids the edge case wherestartis reset to -1 for TSB-less linear streams. Also updated the block comment and downgraded the log from WARN to INFO.Uh oh!
There was an error while loading. Please reload this page.