Updates to RISC-V compiler selection (prefer gcc-riscv32-pico-elf and maximum -march opts)#2921
Open
kilograham wants to merge 4 commits intodevelopfrom
Open
Updates to RISC-V compiler selection (prefer gcc-riscv32-pico-elf and maximum -march opts)#2921kilograham wants to merge 4 commits intodevelopfrom
kilograham wants to merge 4 commits intodevelopfrom
Conversation
… trying different compiler flags until supported ones are found (we try more aggressive -march for RISC-V then less aggressive)
lurch
reviewed
May 5, 2026
lurch
reviewed
May 5, 2026
will-v-pi
reviewed
May 5, 2026
Co-authored-by: Andrew Scheller <lurch@durge.org>
Contributor
|
You can fix the bazel checks by adding |
will-v-pi
reviewed
May 8, 2026
| set(NULL_DEVICE "/dev/null") | ||
| endif() | ||
| foreach(flags IN LISTS ${common_lang_flags_var_list}) | ||
| separate_arguments(COMPILER_CMD NATIVE_COMMAND "${compiler_path} ${flags} -x c -c ${CMAKE_CURRENT_LIST_DIR}/empty.c -o ${NULL_DEVICE}") |
Contributor
There was a problem hiding this comment.
The path needs quoting as it may contain spaces, which then throws the error:
riscv32-unknown-elf-gcc.exe: fatal error: cannot specify '-o' with '-c', '-S' or '-E' with multiple files
Suggested change
| separate_arguments(COMPILER_CMD NATIVE_COMMAND "${compiler_path} ${flags} -x c -c ${CMAKE_CURRENT_LIST_DIR}/empty.c -o ${NULL_DEVICE}") | |
| separate_arguments(COMPILER_CMD NATIVE_COMMAND "${compiler_path} ${flags} -x c -c \"${CMAKE_CURRENT_LIST_DIR}/empty.c\" -o ${NULL_DEVICE}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make gcc-riscv32-pico-elf the preferred compiler, and add support for trying different compiler flags until supported ones are found (we try more aggressive -march for RISC-V then less aggressive)