Skip to content

Add server timeouts#87

Open
raeperd wants to merge 1 commit into
mainfrom
add-server-timeouts
Open

Add server timeouts#87
raeperd wants to merge 1 commit into
mainfrom
add-server-timeouts

Conversation

@raeperd
Copy link
Copy Markdown
Owner

@raeperd raeperd commented May 11, 2026

Summary

Add explicit net/http.Server timeouts:

  • ReadTimeout: 30s
  • WriteTimeout: 60s
  • IdleTimeout: 60s

ReadHeaderTimeout was already set to 10s.

These defaults avoid unbounded request reads, response writes, and idle keep-alive connections while keeping the template simple. WriteTimeout is set to 60s so default pprof profiles can still complete.

Part of #85.

Test

  • go test -race ./...
  • golangci-lint run

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Warning

Rate limit exceeded

@raeperd has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 58 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9667458d-15c6-43ac-bd37-a4f12bfd3d9c

📥 Commits

Reviewing files that changed from the base of the PR and between b58db9e and b45f6d1.

📒 Files selected for processing (1)
  • main.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-server-timeouts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raeperd raeperd self-assigned this May 11, 2026
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 80.128% (+0.4%) from 79.739% — add-server-timeouts into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants