campapp: RGB LED amplifying#141
Open
dos1 wants to merge 2 commits intorad1o:masterfrom
Open
Conversation
Brightness of RGB LED animations varies a lot, and sometimes desired brightness depends on the environment and situation. Aside of editing the animations directly, there was no way to adjust the brightness of the LEDs. This commit introduces a new config entry, "rgbleds_amp", which allows to adjust the brightness of RGB LEDs in campapp animations. The default value of 8 is a neutral setting. Keep in mind that with static animations amp setting does not apply immediately (either the frame delay must pass or the new animation has to be loaded).
Internets say that's the good way so they must be right. https://matt.sh/howto-c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brightness of RGB LED animations varies a lot, and sometimes
desired brightness depends on the environment and situation.
Aside of editing the animations directly, there was no way to
adjust the brightness of the LEDs.
This commit introduces a new config entry, "rgbleds_amp", which
allows to adjust the brightness of RGB LEDs in campapp animations.
The default value of 8 is a neutral setting.
Keep in mind that with static animations amp setting does not
apply immediately (either the frame delay must pass or the new
animation has to be loaded).