Skip to content

hyprland/ipc: use deleteLater() for workspace and toplevel deletion #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simaotwx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hyprland/ipc: use deleteLater() for workspace and toplevel deletion #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/wayland/hyprland/ipc/connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,8 @@ void HyprlandIpc::onEvent(HyprlandIpcEvent* event) {
qCDebug(logHyprlandIpc) << "Workspace removed with id" << id << "name" << name;
this->mWorkspaces.removeAt(index);

// workspaces have not been observed to be referenced after deletion
delete workspace;
// Use deleteLater to ensure QML bindings don't access dangling pointers
workspace->deleteLater();

for (auto* monitor: this->mMonitors.valueList()) {
if (monitor->bindableActiveWorkspace().value() == nullptr) {
Expand Down Expand Up @@ -494,7 +494,8 @@ void HyprlandIpc::onEvent(HyprlandIpcEvent* event) {
workspace->toplevels()->removeObject(toplevel);
}

delete toplevel;
// Use deleteLater to ensure QML bindings don't access dangling pointers
toplevel->deleteLater();
} else if (event->name == "movewindowv2") {
auto args = event->parseView(3);
auto ok = false;
Expand Down Expand Up @@ -662,7 +663,8 @@ void HyprlandIpc::refreshWorkspaces(bool canCreate) {

for (auto* workspace: removedWorkspaces) {
this->mWorkspaces.removeObject(workspace);
delete workspace;
// Use deleteLater to ensure QML bindings don't access dangling pointers
workspace->deleteLater();
}
}
});
Expand Down