Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the install script generation by replacing the deprecated pkgs.substituteAll function with the newer pkgs.replaceVars function. The change simplifies the code by using a more concise API for variable substitution in the install shell script.
Key Changes
- Replaced
pkgs.substituteAllwithpkgs.replaceVarsfor template variable substitution - Simplified the syntax by passing the source file directly as the first argument
- Removed redundant comments about source file and substitution values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.