test: validate all dialect Ref/keyword references resolve#2539
Open
benfdking wants to merge 1 commit into
Open
test: validate all dialect Ref/keyword references resolve#2539benfdking wants to merge 1 commit into
benfdking wants to merge 1 commit into
Conversation
Walks every grammar entry in every dialect and checks that all Ref references (including keywords, bracket pairs, terminators, excludes, and delimiters) point to names that actually exist in the dialect's library. Currently finds 263 unresolved references across 8 dialects to be fixed incrementally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Benchmark for 8d5a2d4Click to view benchmark
|
benfdking
added a commit
that referenced
this pull request
Apr 12, 2026
Already ported - SQLite dialect already sets FetchClauseSegment to Nothing and has SELECT LIMIT test fixtures. Bumping SHA only. Ported from SQLFluff 18e15780904ad9931f12ced01924a95ac8d8de00 sqlfluff/sqlfluff#4566 sqlfluff/sqlfluff@18e1578 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benfdking
added a commit
that referenced
this pull request
Apr 12, 2026
chore: port SQLite SELECT LIMIT fix (#4566) (#2539) Already ported - SQLite dialect already sets FetchClauseSegment to Nothing and has SELECT LIMIT test fixtures. Bumping SHA only. Ported from SQLFluff 18e15780904ad9931f12ced01924a95ac8d8de00 sqlfluff/sqlfluff#4566 sqlfluff/sqlfluff@18e1578 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreferences actually resolve to entries in the dialect's libraryTest plan
🤖 Generated with Claude Code