Provide option for email notification when torrent added#24289
Closed
LewpyUK wants to merge 1 commit into
Closed
Conversation
LewpyUK
force-pushed
the
SMTPExtraNotifications
branch
from
e36893b to
4752c3f
Compare
LewpyUK
changed the title
LewpyUK
force-pushed
the
SMTPExtraNotifications
branch
2 times, most recently
from
7f24e2a to
d96ba49
Compare
LewpyUK
force-pushed
the
SMTPExtraNotifications
branch
2 times, most recently
from
7a52568 to
2640ae1
Compare
Introduce `mail_notification_on_add` and `mail_notification_on_end` options for email notifications. Update GUI and WebUI to allow users to configure these settings. Extend WebAPI endpoints (`app/preferences` and `app/setPreferences`) to support the new options. Update backend logic to respect these preferences and enhance the UI with checkboxes and tooltips for better usability.
LewpyUK
force-pushed
the
SMTPExtraNotifications
branch
from
2640ae1 to
35e8d9f
Compare
Contributor
Author
|
If #24485 goes through, this will not be needed as it could then be done as a plugin |
Member
Contributor
Author
I personally think the plugin system is a good idea 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide the options to send email notifications when a torrent is added and when a torrent finishes.
Currently an email notification is only sent when a torrent finishes.
If you are running qBittorrent with automations, such as RSS feeds & rules, then it is very useful to receive an email when a torrent is added as well as when it finishes, so you can track the progress remotely: receiving an email for a torrent being added that isn't followed by an email saying the torrent is completed alerts you that something needs investigated.
It's personally something I find very useful and I added to my local build of qBittorrent as soon as I made code modifications.
I've arranged them as checkboxes so that it can be extended in the future for other torrent events, if desired.
I've added logic checks so that if only one checkbox is ticked, it is disabled to prevent it being unticked itself, ensuring that at least one options is ticked. It is re-enabled when the other option is ticked.
There is logic to capture the case that someone manages to set both options off (hand edit the config file, or similar), and then it doesn't disable any boxes until something is selected.
Also, a future option could be to have buttons beside each option that allows for customising the email message (perhaps parsed in a similar way to the Run External Program just below).
GUI
WebGUI