[Refactor] Split TensorDict helper functions#1683
Open
vmoens wants to merge 1 commit intopytorch:mainfrom
Open
[Refactor] Split TensorDict helper functions#1683vmoens wants to merge 1 commit intopytorch:mainfrom
vmoens wants to merge 1 commit intopytorch:mainfrom
Conversation
Contributor
PR Title Label ErrorPR title must start with a label prefix in brackets (e.g., Current title: Supported PrefixesYour PR title must start with exactly one of these prefixes (case-insensitive):
Note: Matching is case-insensitive. Common variations (singular/plural) are supported. |
04704bb to
25365c8
Compare
Contributor
PR Title Label ErrorPR title must start with a label prefix in brackets (e.g., Current title: Supported PrefixesYour PR title must start with exactly one of these prefixes (case-insensitive):
Note: Matching is case-insensitive. Common variations (singular/plural) are supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tensordict._tdhelper functions intotensordict._td_functionstensordict._tdas the compatibility facade for these helperstensordictexportsBC notes
tensordict._tdremain validtensordicthelper exports still resolve to the same function objects__module__ == "tensordict._td"Test plan
python -m pytest test/test_compatibility.py::test_td_helper_import_paths_are_preserved -qulimit -n 4096 && python -m pytest test/test_tensordict.py -k "from_module or from_modules or from_pytree or from_consolidated or save_load_memmap or maybe_dense_stack" -qpython -m pytest test/test_compatibility.py -q -k "not redis and not StoreFromSchema and not Preallocation"python -m compileall -q tensordict/_td.py tensordict/_td_functions.pyThe local file descriptor limit is 256, so the memmap-heavy targeted test selection needs
ulimit -n 4096locally.