[BugFix] fix ragged_idx of consolidated tensor#1675
Merged
vmoens merged 3 commits intopytorch:mainfrom Apr 20, 2026
Merged
Conversation
Signed-off-by: Chi Zhang <czhangseu@gmail.com>
Signed-off-by: Chi Zhang <czhangseu@gmail.com>
meta-cla
Bot
added
the
CLA Signed
github-actions
Bot
added
bug
Contributor
Author
|
@vmoens Could you help release a minor version for this fix as it affects the correctness of 3d position ids used in VLM training. Thanks! |
8 tasks
vmoens
approved these changes
Apr 20, 2026
Collaborator
vmoens
left a comment
vmoens
left a comment
There was a problem hiding this comment.
LGTM just a couple of nits
I'll make a minor with it asap
…test - Move `io` and `pickle` to top-level imports in test/test_tensordict.py - Extract the ragged_idx-after-consolidation check into a dedicated `test_consolidate_njt_ragged_idx` test method. Made-with: Cursor
vmoens
pushed a commit
that referenced
this pull request
Apr 20, 2026
Collaborator
|
I've just published 0.12.2 |
Contributor
Author
Great thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
close #1676
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!