Skip to content

Patch AArch64 detection and enable Python 3.12 in Linux AArch64 nightly wheels build#4164

Merged
metascroy merged 1 commit intopytorch:mainfrom
puneetmatharu:patch-machine-detection-in-env-var-script-linux
Apr 16, 2026
Merged

Patch AArch64 detection and enable Python 3.12 in Linux AArch64 nightly wheels build#4164
metascroy merged 1 commit intopytorch:mainfrom
puneetmatharu:patch-machine-detection-in-env-var-script-linux

Conversation

@puneetmatharu
Copy link
Copy Markdown
Contributor

Summary

This PR patches the machine checks in the Linux packaging env script (for gating AArch64-specific build flags) and updates the Linux AArch64 wheel build to include Python 3.12.

Changes

  • Add Python 3.12 to .github/workflows/build_wheels_linux_aarch64.yml
  • Replace the regex-based uname -m check in packaging/env_var_script_linux.sh with explicit aarch64 and arm64 comparisons
  • Keep the AArch64-only build flags gated to ARM machines while making the detection logic more predictable in CI

Why

We attempted to sort the CI out with this PR, but the CI runs after it indicate that the machine detection was not done correctly which this patch detects.

Additionally, it is important for our library Tool Solutions to have Python 3.12 wheels of torch so we don't need to build it from source, which is why I've added that to the CI.

Testing

  • I ran the same tests as I did for the previous PR and they passed.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 24, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4164

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1dd16ed with merge base 00ef369 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2026
@puneetmatharu
Copy link
Copy Markdown
Contributor Author

CC @metascroy since you were able to review my last PR.

@aditew01
Copy link
Copy Markdown

@digantdesai can you please help with the review?

@puneetmatharu
Copy link
Copy Markdown
Contributor Author

@metascroy bump. Would be great to get some traction on this asap, please.

@puneetmatharu
Copy link
Copy Markdown
Contributor Author

@aditew01 @nikhil-arm how should we escalate this? We don't want it to go stale.

@nikhil-arm
Copy link
Copy Markdown
Contributor

Pinged torchao team, lets wait for their reply.

Copy link
Copy Markdown
Contributor

@metascroy metascroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's see what CI says

@puneetmatharu puneetmatharu force-pushed the patch-machine-detection-in-env-var-script-linux branch from ca97115 to 1dd16ed Compare April 15, 2026 09:43
@puneetmatharu
Copy link
Copy Markdown
Contributor Author

puneetmatharu commented Apr 15, 2026

These tests had failures due to a bug in the CI that was fixed 2 weeks ago here, unrelated to my changes. I've rebased on main to pull in the fixes.

@metascroy can we rerun the tests please?

@metascroy
Copy link
Copy Markdown
Contributor

Re-running tests after rebase

@metascroy metascroy merged commit f87f11e into pytorch:main Apr 16, 2026
38 of 39 checks passed
@puneetmatharu puneetmatharu deleted the patch-machine-detection-in-env-var-script-linux branch April 22, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants