[moe training] default pad_token_groups_for_grouped_mm=False#4080
Merged
danielvegamyhre merged 1 commit intomainfrom Mar 14, 2026
Merged
[moe training] default pad_token_groups_for_grouped_mm=False#4080danielvegamyhre merged 1 commit intomainfrom
danielvegamyhre merged 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4080
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit b6bf1a5 with merge base eb64bfb ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
f6a27bd to
10362fc
Compare
drisspg
approved these changes
Mar 13, 2026
7911823 to
5eb9e5e
Compare
5eb9e5e to
b6bf1a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pad_token_groups_for_grouped_mmto False to avoid surprising users with the extra pad/unpad kernels that incur overhead. This is often handled upstream of the quantization + grouped MM step now, by systems like HybridEP etc, so best for the user to explicitly request the padding via the flag if they need it.Tests
pytest test/prototype/moe_training/test_training.py -s