Upgrade torchao build configs to C++20 (#4025)#4025
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Mar 23, 2026
Merged
Upgrade torchao build configs to C++20 (#4025)#4025meta-codesync[bot] merged 1 commit intopytorch:mainfrom
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4025
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
andrewor14
added
the
topic: for developers
andrewor14
approved these changes
Mar 9, 2026
r-barnes
added
the
module: not user facing
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: 1 mandatory check(s) are pending/not yet run. The first few are:
Dig deeper by viewing the pending checks on hud |
Contributor
Author
|
@pytorchbot merge -f "CLA satisfied" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) are pending/not yet run. The first few are:
Dig deeper by viewing the pending checks on hud |
r-barnes
force-pushed
the
export-D95103084
branch
from
2caed41 to
d268c4a
Compare
r-barnes
added a commit
to r-barnes/ao
that referenced
this pull request
Mar 12, 2026
Summary: Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20 in torchao's setup.py, CMakeLists.txt, and Makefile files. Reviewed By: andrewor14 Differential Revision: D95103084
meta-codesync
Bot
changed the title
r-barnes
force-pushed
the
export-D95103084
branch
from
d268c4a to
a982fcc
Compare
r-barnes
added a commit
to r-barnes/ao
that referenced
this pull request
Mar 14, 2026
Summary: Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20 in torchao's setup.py, CMakeLists.txt, and Makefile files. Reviewed By: andrewor14 Differential Revision: D95103084
Contributor
Author
|
If regression tests don't fail after rebase, we should be good. |
r-barnes
added a commit
to r-barnes/ao
that referenced
this pull request
Mar 14, 2026
Summary: Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20 in torchao's setup.py, CMakeLists.txt, and Makefile files. Reviewed By: andrewor14 Differential Revision: D95103084
r-barnes
force-pushed
the
export-D95103084
branch
from
a982fcc to
bd29912
Compare
r-barnes
added a commit
to r-barnes/ao
that referenced
this pull request
Mar 14, 2026
Summary: Pull Request resolved: pytorch#4025 Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20 in torchao's setup.py, CMakeLists.txt, and Makefile files. Reviewed By: andrewor14 Differential Revision: D95103084
r-barnes
force-pushed
the
export-D95103084
branch
from
bd29912 to
76b76b9
Compare
r-barnes
force-pushed
the
export-D95103084
branch
from
76b76b9 to
ae95ea8
Compare
r-barnes
added a commit
to r-barnes/ao
that referenced
this pull request
Mar 22, 2026
Summary: Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20 in torchao's setup.py, CMakeLists.txt, and Makefile files. Reviewed By: andrewor14 Differential Revision: D95103084
r-barnes
added a commit
to r-barnes/ao
that referenced
this pull request
Mar 22, 2026
Summary: Pull Request resolved: pytorch#4025 Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20 in torchao's setup.py, CMakeLists.txt, and Makefile files. Reviewed By: andrewor14 Differential Revision: D95103084
r-barnes
force-pushed
the
export-D95103084
branch
from
ae95ea8 to
5c5102c
Compare
Summary: Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20 in torchao's setup.py, CMakeLists.txt, and Makefile files. Reviewed By: andrewor14 Differential Revision: D95103084
r-barnes
force-pushed
the
export-D95103084
branch
from
5c5102c to
442ae65
Compare
pytorch-bot Bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 14, 2026
Bump the torchao commit pin to fbce9178 which includes pytorch/ao#4025 (Upgrade torchao build configs to C++20). This is needed because #178150 enforces C++20 in ATen.h header guards, and the old pin built CUDA extensions with -std=c++17, causing compilation failures in the inductor CI.
r-barnes
added a commit
to r-barnes/pytorch
that referenced
this pull request
Apr 14, 2026
Bump the torchao commit pin to fbce9178 which includes pytorch/ao#4025 (Upgrade torchao build configs to C++20). This is needed because pytorch#178150 enforces C++20 in ATen.h header guards, and the old pin built CUDA extensions with -std=c++17, causing compilation failures in the inductor CI.
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 14, 2026
## Summary - Bump torchao pin from `985d970b` to `fbce9178` (pytorch/ao#4025) - The new pin builds CUDA extensions with `-std=c++20` instead of `-std=c++17` - Fixes the inductor build failure introduced by #178150 (C++20 header guards in ATen.h) ## Test plan - Inductor CI build should pass (torchao CUDA extensions now compile with C++20) Pull Request resolved: #180302 Approved by: https://github.com/Skylion007
BoyuanFeng
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Apr 15, 2026
## Summary - Bump torchao pin from `985d970b` to `fbce9178` (pytorch/ao#4025) - The new pin builds CUDA extensions with `-std=c++20` instead of `-std=c++17` - Fixes the inductor build failure introduced by #178150 (C++20 header guards in ATen.h) ## Test plan - Inductor CI build should pass (torchao CUDA extensions now compile with C++20) Pull Request resolved: #180302 Approved by: https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update CMAKE_CXX_STANDARD and compiler flags from c++17 to c++20
in torchao's setup.py, CMakeLists.txt, and Makefile files.
Reviewed By: andrewor14
Differential Revision: D95103084