Skip to content

Fix wordings in threads.rst for correctness - #149576

Closed
ghost wants to merge 1 commit into
mainfrom
unknown repository
Closed

Fix wordings in threads.rst for correctness#149576
ghost wants to merge 1 commit into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented May 8, 2026

Copy link
Copy Markdown

This PR fixes a minor inconsistency in wordings used in Doc/c-api/threads.rst

as the interpreter needs to keep track of which threads may access Python objects.

@ghost
ghost requested a review from ZeroIntensity as a code owner May 8, 2026 18:38
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 8, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 8, 2026
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32608467 | 📁 Comparing 1b914c7 against main (ebf6d9c)

  🔍 Preview build  

3 files changed
± c-api/threads.html
± whatsnew/3.16.html
± whatsnew/changelog.html

@picnixz

picnixz commented May 8, 2026

Copy link
Copy Markdown
Member

Is it really correct now? there is a difference between the threads that can access objects and threads that are known to access objects. The new wording is too generic and wrong IMO. cc @ZeroIntensity

@ZeroIntensity

Copy link
Copy Markdown
Member

Yeah, I don't think this is correct.

"threads" here refers to OS threads (in contrast to "Python" threads, which have a live thread state), so I find the phrase "[OS] threads which may access Python objects" to be confusing, because it reads as if any thread may eventually access an object at some point, which is not necessarily true. In comparison, "which [OS] threads" makes it clear that only certain threads are allowed to access objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants