Skip to content

Fix heading hierarchy for accessibility #19824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muratclk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix heading hierarchy for accessibility #19824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion warehouse/static/sass/blocks/_verified.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
padding-bottom: 0;
}

h6 {
h4 {
font-size: 1rem;
padding-bottom: 5px;
padding-top: 15px;
}
Expand Down
18 changes: 9 additions & 9 deletions warehouse/templates/includes/packaging/project-data.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h3 class="sidebar-section__title">
</h3>
<small><i>{% trans href="https://docs.pypi.org/project_metadata/#verified-details" %}These details have been <a href="{{ href }}">verified by PyPI</a>{% endtrans %}</i></small>
{% if release.urls_by_verify_status(verified=True).values() | contains_valid_uris %}
<h6>{% trans %}Project links{% endtrans %}</h6>
<h4>{% trans %}Project links{% endtrans %}</h4>
<ul class="vertical-tabs__list">
{% for name, url in release.urls_by_verify_status(verified=True).items() %}
{% if is_valid_uri(url) %}
Expand All @@ -33,7 +33,7 @@ <h6>{% trans %}Project links{% endtrans %}</h6>
</ul>
{% endif %}
{% if project.organization %}
<h6>Owner</h6>
<h4>Owner</h4>
<ul class="vertical-tabs__list">
<li>
<a class="vertical-tabs__tab vertical-tabs__tab--with-icon vertical-tabs__tab--condensed"
Expand All @@ -46,7 +46,7 @@ <h6>Owner</h6>
</ul>
{% endif %}
{% if release.verified_github_repo_info_url and release.verified_github_open_issue_info_url %}
<h6>{% trans %}GitHub Statistics{% endtrans %}</h6>
<h4>{% trans %}GitHub Statistics{% endtrans %}</h4>
<div class="hidden github-repo-info" data-controller="github-repo-info">
<ul class="vertical-tabs__list">
<li>
Expand Down Expand Up @@ -97,7 +97,7 @@ <h6>{% trans %}GitHub Statistics{% endtrans %}</h6>
</div>
{% endif %}
{% if release.verified_gitlab_repository %}
<h6>{% trans %}GitLab Statistics{% endtrans %}</h6>
<h4>{% trans %}GitLab Statistics{% endtrans %}</h4>
<div class="hidden gitlab-repo-info" data-controller="gitlab-repo-info">
<ul class="vertical-tabs__list">
<li>
Expand Down Expand Up @@ -148,7 +148,7 @@ <h6>{% trans %}GitLab Statistics{% endtrans %}</h6>
</div>
{% endif %}
{% if maintainers %}
<h6>{% trans %}Maintainers{% endtrans %}</h6>
<h4>{% trans %}Maintainers{% endtrans %}</h4>
{% for maintainer in maintainers %}
{% set alt = gettext("Avatar for {username} from gravatar.com").format(username=maintainer.username) %}
<span class="sidebar-section__maintainer">
Expand All @@ -168,7 +168,7 @@ <h6>{% trans %}Maintainers{% endtrans %}</h6>
{% endif %}
{% if release.has_meta and (release.author_email_verified or release.maintainer_email_verified) %}
<div class="sidebar-section verified">
<h6>{% trans %}Meta{% endtrans %}</h6>
<h4>{% trans %}Meta{% endtrans %}</h4>
<ul>
{% if release.author_email and release.author_email_verified %}
<li>
Expand All @@ -192,7 +192,7 @@ <h6>{% trans %}Meta{% endtrans %}</h6>
<h3 class="sidebar-section__title">{% trans %}Unverified details{% endtrans %}</h3>
<small><i>{% trans %}These details have <b>not</b> been verified by PyPI{% endtrans %}</i></small>
{% if release.urls_by_verify_status(verified=False).values() | contains_valid_uris %}
<h6>{% trans %}Project links{% endtrans %}</h6>
<h4>{% trans %}Project links{% endtrans %}</h4>
<ul class="vertical-tabs__list">
{% for name, url in release.urls_by_verify_status(verified=False).items() %}
{% if is_valid_uri(url) %}
Expand All @@ -207,7 +207,7 @@ <h6>{% trans %}Project links{% endtrans %}</h6>
{% endif %}
{% if release.has_meta %}
<div class="sidebar-section unverified">
<h6>{% trans %}Meta{% endtrans %}</h6>
<h4>{% trans %}Meta{% endtrans %}</h4>
<ul>
{% if release.license_expression %}
<li>
Expand Down Expand Up @@ -293,7 +293,7 @@ <h6>{% trans %}Meta{% endtrans %}</h6>
{% endif %}
{% if release.classifiers %}
<div class="sidebar-section unverified">
<h6 class="sidebar-section__title">{% trans %}Classifiers{% endtrans %}</h6>
<h4 class="sidebar-section__title">{% trans %}Classifiers{% endtrans %}</h4>
<ul class="sidebar-section__classifiers">
{% for classifier_head, classifier_tails in (release.classifiers|format_classifiers()).items() %}
<li>
Expand Down
2 changes: 1 addition & 1 deletion warehouse/templates/packaging/detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ <h1 class="package-header__name">{{ release.project.name }} {{ release.version }
<div class="vertical-tabs">
<div class="vertical-tabs__tabs">
<div class="sidebar-section">
<h3 class="sidebar-section__title">{% trans %}Navigation{% endtrans %}</h3>
<h2 class="sidebar-section__title">{% trans %}Navigation{% endtrans %}</h2>
<nav aria-label="{% trans project=release.project.name %}Navigation for {{ project }}{% endtrans %}">
<ul class="vertical-tabs__list" role="tablist">
<li role="tab">
Expand Down
Loading