Set up delvewheel as the default repair wheel command for Windows#2831
Set up delvewheel as the default repair wheel command for Windows#2831agriyakhetarpal wants to merge 21 commits intopypa:mainfrom
delvewheel as the default repair wheel command for Windows#2831Conversation
|
One of the concerns we had was listed in #2047 (comment), about users having to add |
|
Thanks, I appreciate that:) I'll just reiterate that IMO this is a more general Windows limitation, they don't have a proper system package manager (EDIT: though I did see a |
Suggested-by: Nils <nilsnolde@proton.me>
Good point, thanks @nilsnolde. I agree that vcpkg is the closest to this kind of thing out there (and even Meson wraps is one more option). I added a note in 8cfdbf7. Does that suffice? :) |
This comment was marked as resolved.
This comment was marked as resolved.
@agriyakhetarpal IMO sounds perfect, thanks! |
|
By the way, I just made a new delvewheel release 1.12.1, which automatically excludes the DLLs provided by or required by GraalPy ( |
|
Awesome, thanks a lot @adang1345! |
Co-authored-by: Aohan Dang <adang1345@gmail.com>
joerick
left a comment
There was a problem hiding this comment.
Thanks for working on this agriya!
Looks good from my end overall.
|
While I'm thinking about it, this is a change that needs a good notice in release notes. Things to mention in the release notes
I think the crucial thing to mention in release notes will be how to disable it for upgrading users that don't want this change yet. |
This partially reverts commit 2dc4c0f.
|
FYI, I partially reverted the constraints bumps in 17d38ba because there was a failure likely due to |
This PR adds
delvewheelin the usual places for it to the default wheel repair command for our Windows platform in cibuildwheel v4. The current version is v1.12.0, and the project has become fairly stable as of 2026.I think I covered everything, but please LMK if I missed anything. @joerick, since you expressed interest in adding this in various issues, it'd be great if you could take a look – and by all means, please feel free to push any further changes to my PR!
Also, cc: @adang1345 (I hope it is okay for us to ping you here!)
Thank you! :)
delvewheelas default for windows repair command #2803Also, perhaps we should look at #1567 too while we're at it, based on the open issues that reference "delvewheel".