-
Notifications
You must be signed in to change notification settings - Fork 312
Pyodide updates: pyemscripten platform tag (PEP 783), 314.0a1, pyodide-eol flag, and maintenance updates
#2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 30 commits
87bcefe
17679b8
2df97d1
4bd785d
499e965
8064a46
ac56575
52fa455
46a2627
088d6e5
455e568
9396cae
f0289d8
9749c11
e3c8ca1
f4e5229
3fe3394
6092434
87c1be7
40ffec0
18ea0fc
e50d138
829392f
0a4abb6
1960c6e
44bdfbc
f4255af
8fc1e7c
ff16b28
d408f03
11490ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -226,7 +226,8 @@ python_configurations = [ | |
| [pyodide] | ||
| python_configurations = [ | ||
| { identifier = "cp312-pyodide_wasm32", version = "3.12", default_pyodide_version = "0.27.7", node_version = "v22" }, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason to remove 3.12 here?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, since I don't think it's useful to have three ABIs enabled at once. We don't support anything but the latest version. Pyodide 0.29.3 and 314.0.0a1 have two different ABIs, which should be enough? Since we don't have a stable 314.0.0 release and IMO cibuildwheel shouldn't be as disruptive to users' workflows, I think it's okay to keep 0.29.3 – but three different ABIs becomes a bit excessive. People can still build for arbitrary (read: older) versions, such as Pyodide 0.27.7, using
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the usage of the old versions? IMO, people can upgrade, and probably should, but it's also easy to forget. I'm sure I have webpages that are using old versions. I think the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Per jsdelivr, the most-used version is Python 3.12, followed by 3.13 and 3.10 which are almost tied.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
What's the excess you're considering? The requirement for the user to grab 3 different emscripten toolchains? I think that supporting 3 current + one prerelease version seems quite reasonable to me going forward. But perhaps we'd like to hide one or two behind a This current scenario might be an exception, though, as the package consumer is gonna need to upgrade something anyway, so I can see the argument to drop more aggressively here. In summary, my (weakly held) opinion would be to drop 3.12 now, but going forward, I'm open to supporting more versions than the current behind a
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, so I think Edit: okay, I have now added 3.12 back, behind a |
||
| { identifier = "cp313-pyodide_wasm32", version = "3.13", default_pyodide_version = "0.29.3", node_version = "v22" }, | ||
| { identifier = "cp313-pyodide_wasm32", version = "3.13", default_pyodide_version = "0.29.4", node_version = "v22" }, | ||
| { identifier = "cp314-pyodide_wasm32", version = "3.14", default_pyodide_version = "314.0.0a1", node_version = "v24" }, | ||
| ] | ||
|
|
||
| [android] | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.