-
Notifications
You must be signed in to change notification settings - Fork 312
Pyodide updates: pyemscripten platform tag (PEP 783), 314.0a1, pyodide-eol flag, and maintenance updates
#2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
87bcefe
17679b8
2df97d1
4bd785d
499e965
8064a46
ac56575
52fa455
46a2627
088d6e5
455e568
9396cae
f0289d8
9749c11
e3c8ca1
f4e5229
3fe3394
6092434
87c1be7
40ffec0
18ea0fc
e50d138
829392f
0a4abb6
1960c6e
44bdfbc
f4255af
8fc1e7c
ff16b28
d408f03
11490ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,11 +140,20 @@ def test_dependency_constraints( | |
| project_dir = tmp_path / "project" | ||
| test_projects.new_c_project().generate(project_dir) | ||
|
|
||
| tool_versions = { | ||
| "pip": "23.1.2", | ||
| "build": "1.2.2", | ||
| "delocate": "0.10.3", | ||
| } | ||
| if utils.get_platform() == "pyodide": | ||
| # pyodide-build 0.34+ requires build~=1.4.0, so we must use a | ||
| # compatible version here. delocate is macOS-only and not used on pyodide. | ||
| tool_versions = { | ||
| "pip": "23.1.2", | ||
| "build": "1.4.2", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what happens if we use build 1.4 or 1.5 for all cases?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It now supports 1.4 and 1.5, but it's highly constrained due to worries about it using build's internals. Those are generally okay, I think. I think the reason for 1.2.2 was likely older Python support, but we are dropping 3.9 so hopefully that's better now. |
||
| "delocate": "0.10.3", | ||
| } | ||
| else: | ||
| tool_versions = { | ||
| "pip": "23.1.2", | ||
| "build": "1.2.2", | ||
| "delocate": "0.10.3", | ||
| } | ||
|
|
||
| if method == "file": | ||
| constraints_file = tmp_path / "constraints file.txt" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -414,14 +414,14 @@ def _expected_wheels( | |
|
|
||
| elif platform == "pyodide": | ||
| platform_tags = { | ||
| "cp312-cp312": ["pyodide_2024_0_wasm32"], | ||
| "cp313-cp313": ["pyodide_2025_0_wasm32"], | ||
| "cp312-cp312": ["pyemscripten_2024_0_wasm32"], | ||
|
henryiii marked this conversation as resolved.
Outdated
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The existing tags should stay the same right? There is no version of Pyodide that accepts a wheel tagged
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe this is a regression, then. @ryanking13, were we too early in changing to the
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I am not sure to be honest. If we keep the I am personally +1 for using the
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, given that users do have an option to update micropip, and now that the first alpha of 314.0 is out (thanks to you!), I will add it in this PR and drop Pyodide 0.27.7. Will that resolve your concerns, @hoodmane? Or, do you think that cibuildwheel should work around it now, and rename
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If a patch release of pyodide 3.13 with updated micropip was possible, then I'd go:
If a patch release is hard to do... Well, that's uglier. Are these "normal" enough that
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is now a v0.29.4 patch release: https://github.com/pyodide/pyodide/releases/tag/0.29.4. Updating to it! |
||
| "cp313-cp313": ["pyemscripten_2025_0_wasm32"], | ||
| }.get(python_abi_tag, []) | ||
|
|
||
| if not platform_tags: | ||
| # for example if the python tag is `none` or `abi3`, all | ||
| # platform tags are built with that python tag | ||
| platform_tags = ["pyodide_2024_0_wasm32"] | ||
| platform_tags = ["pyemscripten_2024_0_wasm32"] | ||
|
|
||
| else: | ||
| msg = f"Unsupported platform {platform!r}" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.