feat: Support Composite Global Secondary Indexes#1303
Open
keremeyuboglu wants to merge 8 commits intopynamodb:masterfrom
Open
feat: Support Composite Global Secondary Indexes#1303keremeyuboglu wants to merge 8 commits intopynamodb:masterfrom
keremeyuboglu wants to merge 8 commits intopynamodb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for composite Global Secondary Index keys, including multiple hash key and range key attributes declared on a GSI. The implementation preserves declaration order when building index schemas and query key conditions.
See: #1293
For the query API, I created a separate hash_keys parameter for composite partition keys instead of changing the existing hash_key parameter to also accept dictionaries, but unsure if it would have been better to merge this new logic onto the hash_key parameter instead.