Fix bug in fit_laplace when model has exactly one variable#437
Merged
fonnesbeck merged 1 commit intopymc-devs:mainfrom Mar 21, 2025
Merged
Fix bug in fit_laplace when model has exactly one variable#437fonnesbeck merged 1 commit intopymc-devs:mainfrom
fonnesbeck merged 1 commit intopymc-devs:mainfrom
Conversation
Member
|
Why not use the numpy one that doesn't have that stupid squeeze behavior? |
velochy
pushed a commit
to velochy/pymc-extras
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a mean vector has exactly one element,
scipy.stats.multivariate_normal.rvssqueezes the leading dimension, which was causing errors infit_laplacefor models with exactly one parameter.This PR patches the behavior by adding a check for this corner case.