refactor: WPB-19709 remove imaging dependency from image flows#923
Conversation
cristianoliveira
changed the title
cristianoliveira
force-pushed
the
WPB-19709-pydio-cells-outdated-and-vulnerable-dependencies-wre-06-001-wp-1-low-info
branch
2 times, most recently
from
30a5361 to
9f6433f
Compare
cdujeu
left a comment
cdujeu
left a comment
There was a problem hiding this comment.
Okay, that one is pretty touchy ;-)
I'm more than happy if we can get rid of this lib. That said, I need some more proofs that this is for good ;-)
Can we produce some comparison between old lib and new implementation:
Performances
The most important thing - performances comparison between old one and new one for creating a high number of thumbnails, thumbnails from large images, etc.. CPU/ops
Rendering
Could we eventually compare rendered images with same setting (and same performances). No surprise of a blurry stuff, etc... One important caveats are transparent PNGs - to be checked
Exif & orientation
Seems to be part of the tests already
cristianoliveira
force-pushed
the
WPB-19709-pydio-cells-outdated-and-vulnerable-dependencies-wre-06-001-wp-1-low-info
branch
from
299386e to
d99b850
Compare
|
After further investigation I found out this PR with a patch disintegration/imaging#175 but more important, a maintained fork https://github.com/boxes-ltd/imaging |
cristianoliveira
deleted the
WPB-19709-pydio-cells-outdated-and-vulnerable-dependencies-wre-06-001-wp-1-low-info
branch
2 participants
Refer to https://wearezeta.atlassian.net/browse/WPB-19709 replacing
github.com/disintegration/imaging