Skip to content

BalloonEval: escape double quotes and new line characters#908

Open
gagara wants to merge 1 commit into
puremourning:masterfrom
gagara:balloon-eval-escape-chars
Open

BalloonEval: escape double quotes and new line characters#908
gagara wants to merge 1 commit into
puremourning:masterfrom
gagara:balloon-eval-escape-chars

Conversation

@gagara

@gagara gagara commented Feb 9, 2025

Copy link
Copy Markdown

Escape " and \n characters in BalloonEval selection.
Fixes #460

@puremourning

Copy link
Copy Markdown
Owner

This change is Reviewable

@puremourning

Copy link
Copy Markdown
Owner

Thanks for sending a patch!

Please can you elaborate on the rationale for this approach and how you tested it and confirmed it works and doesn't regress?

@gagara

gagara commented Feb 9, 2025

Copy link
Copy Markdown
Author

If we consider following code snippet

        String s = "line1" +
            "line2";

if we try to evaluate either "line1" or both "line1" + "line2" then we will get an error (see #460).
This fix should allow mentioned evaluations.
Unit tests are green, that is why I expect no regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VimspectorBalloonEval throws error when evaluating expression with quotes

2 participants