fix: also pass the loop video option on the native player#1614
Open
loge5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rolf Loges <loges.rolf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1578 I added the option "loop video".
Unfortunately I didn't realize that the Android app is using a native player.
So with this fix, also the native player is using the "loop video" option.
Implementation detail:
Because the app and the server may not be updated by the user at the same time, we have to provide backwards compatibility. I had to create a second
playVideomethod:playVideo2. I tested it with two signatures ofplayVideoin the android part, but an older App would not been able to play a video from a newer server.I tested all server and app combinations with different versions (with this fix vs. without).