Skip to content

Improved EXIF parsing for Android App #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
difanta wants to merge 3 commits into
base: master
Choose a base branch
from
+646 −69
Open

Improved EXIF parsing for Android App #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
722700b
Improved EXIF parsing for Android App
difanta Jan 13, 2026
196ebf5
cleanup code into a separate DateParser class;
difanta Jan 20, 2026
3cc970e
move DateParser into separate file
difanta Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,19 @@ android {
buildFeatures {
viewBinding true
}

testOptions {
unitTests.all {
useJUnitPlatform()

testLogging {
events "skipped", "failed"
showStandardStreams = false // set to true to debug tests
exceptionFormat = "full"
}
}
unitTests.returnDefaultValues = true
}
}

dependencies {
Expand All @@ -59,4 +72,9 @@ dependencies {

implementation "com.squareup.okhttp3:okhttp:5.3.2"
implementation "io.github.g00fy2:versioncompare:1.5.0"

testImplementation 'org.junit.jupiter:junit-jupiter-api:5.14.2'
testImplementation "io.mockk:mockk:1.14.9"
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'
testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.14.2'
}
136 changes: 67 additions & 69 deletions android/app/src/main/java/gallery/memories/mapper/SystemImage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,28 @@ package gallery.memories.mapper

import android.content.ContentUris
import android.content.Context
import android.icu.text.SimpleDateFormat
import android.icu.util.TimeZone
import android.net.Uri
import android.provider.MediaStore
import android.util.Log
import androidx.exifinterface.media.ExifInterface
import org.json.JSONObject
import java.io.IOException
import java.io.InputStream
import java.math.BigInteger
import java.security.MessageDigest
import gallery.memories.utility.DateParser

class SystemImage {
var fileId = 0L
var baseName = ""
var mimeType = ""
var dateTaken = 0L
var dateTaken = 0L // seconds
var dayId: Long = 0L
var exifInterface: ExifInterface? = null
var height = 0L
var width = 0L
var size = 0L
var mtime = 0L
var mtime = 0L // seconds
var dataPath = ""
var bucketId = 0L
var bucketName = ""
Expand All @@ -41,6 +43,31 @@ class SystemImage {
val IMAGE_URI = MediaStore.Images.Media.EXTERNAL_CONTENT_URI
val VIDEO_URI = MediaStore.Video.Media.EXTERNAL_CONTENT_URI

/**
* Create ExifInterface from Uri if possible (prefers InputStream for scoped storage),
* falls back to dataPath (file path) if provided.
*/
private fun createExifInterfaceFromUri(ctx: Context, uri: Uri, dataPath: String?): ExifInterface? {
try {
// Try input stream first (works on scoped storage)
ctx.contentResolver.openInputStream(uri)?.use { input ->
return ExifInterface(input)
}
} catch (e: Exception) {
Log.v(TAG, "openInputStream failed for $uri: ${e.message}")
}

// Fallback to file path (DATA) if available
if (!dataPath.isNullOrEmpty()) {
try {
return ExifInterface(dataPath)
} catch (e: Exception) {
Log.w(TAG, "ExifInterface(file) failed for $dataPath: ${e.message}")
}
}
return null
}

/**
* Iterate over all images/videos in the given collection
* @param ctx Context - application context
Expand Down Expand Up @@ -91,6 +118,7 @@ class SystemImage {
val dataColumn = projection.indexOf(MediaStore.Images.Media.DATA)
val bucketIdColumn = projection.indexOf(MediaStore.Images.Media.BUCKET_ID)
val bucketNameColumn = projection.indexOf(MediaStore.Images.Media.BUCKET_DISPLAY_NAME)
val durationColumn = if (collection == VIDEO_URI) projection.indexOf(MediaStore.Video.Media.DURATION) else -1

// Query content resolver
ctx.contentResolver.query(
Expand All @@ -100,37 +128,49 @@ class SystemImage {
selectionArgs,
sortOrder
).use { cursor ->
while (cursor!!.moveToNext()) {
if (cursor == null) {
Log.w(TAG, "ContentResolver.query returned null for $collection")
return@sequence
}

while (cursor.moveToNext()) {
val image = SystemImage()

// Common fields
image.fileId = cursor.getLong(idColumn)
image.baseName = cursor.getString(nameColumn)
image.mimeType = cursor.getString(mimeColumn)
image.baseName = cursor.getString(nameColumn) ?: ""
image.mimeType = cursor.getString(mimeColumn) ?: ""
image.height = cursor.getLong(heightColumn)
image.width = cursor.getLong(widthColumn)
image.size = cursor.getLong(sizeColumn)
image.dateTaken = cursor.getLong(dateTakenColumn)
image.mtime = cursor.getLong(dateModifiedColumn)
image.dataPath = cursor.getString(dataColumn)

image.dataPath = cursor.getString(dataColumn) ?: ""
image.bucketId = cursor.getLong(bucketIdColumn)
image.bucketName = cursor.getString(bucketNameColumn)
image.bucketName = cursor.getString(bucketNameColumn) ?: ""
image.mCollection = collection
image.exifInterface = createExifInterfaceFromUri(ctx, image.uri, image.dataPath)

image.isVideo = collection == VIDEO_URI
if (image.isVideo && durationColumn >= 0) {
image.videoDuration = cursor.getLong(durationColumn)
}

val dateTaken = if (!cursor.isNull(dateTakenColumn)) cursor.getLong(dateTakenColumn) / 1000 else null

// Infer the earliest date from any source
var zonedDateTime = DateParser.inferEarliestDate(image.exifInterface, image.mimeType, dateTaken, image.baseName, image.mtime)

// store the date taken in seconds since epoch (UTC)
image.dateTaken = zonedDateTime.toEpochSecond()

image.dayId = DateParser.getDayId(zonedDateTime)

// Swap width/height if orientation is 90 or 270
val orientation = cursor.getInt(orientationColumn)
if (orientation == 90 || orientation == 270) {
image.width = image.height.also { image.height = image.width }
}

// Video specific fields
image.isVideo = collection == VIDEO_URI
if (image.isVideo) {
val durationColumn = projection.indexOf(MediaStore.Video.Media.DURATION)
image.videoDuration = cursor.getLong(durationColumn)
}

// Add to main list
yield(image)
}
}
Expand Down Expand Up @@ -164,7 +204,7 @@ class SystemImage {
.put(Fields.Photo.WIDTH, width)
.put(Fields.Photo.SIZE, size)
.put(Fields.Photo.ETAG, mtime.toString())
.put(Fields.Photo.EPOCH, epoch)
.put(Fields.Photo.EPOCH, dateTaken)

if (isVideo) {
obj.put(Fields.Photo.ISVIDEO, 1)
Expand All @@ -174,46 +214,8 @@ class SystemImage {
return obj
}

/** The epoch timestamp of the image. */
val epoch
get(): Long {
return dateTaken / 1000
}

val exifInterface
get() : ExifInterface? {
if (isVideo) return null
try {
return ExifInterface(dataPath)
} catch (e: Exception) {
Log.w(TAG, "Failed to read EXIF data: " + e.message)
return null
}
}

/** The UTC dateTaken timestamp of the image. */
fun utcDate(exif: ExifInterface?): Long {
// Get EXIF date using ExifInterface if image
if (exif != null) {
try {
val exifDate = exif.getAttribute(ExifInterface.TAG_DATETIME)
?: throw IOException()
val sdf = SimpleDateFormat("yyyy:MM:dd HH:mm:ss")
sdf.timeZone = TimeZone.GMT_ZONE
sdf.parse(exifDate).let {
return it.time / 1000
}
} catch (e: Exception) {
Log.w(TAG, "Failed to read EXIF datetime: " + e.message)
}
}

// No way to get the actual local date, so just assume current timezone
return (dateTaken + TimeZone.getDefault().getOffset(dateTaken).toLong()) / 1000
}

fun auid(): String {
return md5("$epoch$size")
return md5("$dateTaken$size")
}

fun buid(exif: ExifInterface?): String {
Expand All @@ -224,11 +226,10 @@ class SystemImage {
?: throw IOException()
sfx = "iuid=$iuid"
} catch (e: Exception) {
Log.w(TAG, "Failed to read EXIF unique ID ($baseName): " + e.message)
Log.w(TAG, "Failed to read EXIF unique ID ($baseName): ${e.message}")
}
}

return md5("$baseName$sfx");
return md5("$baseName$sfx")
}

/**
Expand All @@ -237,16 +238,13 @@ class SystemImage {
*/
val photo
get(): Photo {
val exif = exifInterface
val dateCache = utcDate(exif)

return Photo(
localId = fileId,
auid = auid(),
buid = buid(exif),
buid = buid(exifInterface),
mtime = mtime,
dateTaken = dateCache,
dayId = dateCache / 86400,
dateTaken = dateTaken,
dayId = dayId,
baseName = baseName,
bucketId = bucketId,
bucketName = bucketName,
Expand All @@ -259,4 +257,4 @@ class SystemImage {
val md = MessageDigest.getInstance("MD5")
return BigInteger(1, md.digest(input.toByteArray())).toString(16).padStart(32, '0')
}
}
}
Loading